Add "previewing on hover" support for password field.

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 621 matching lines @@
 
 }  // namespace
 
 const size_t kMaxParseableFields = 200;
 
 bool IsMonthInput(const WebInputElement* element) {
   CR_DEFINE_STATIC_LOCAL(WebString, kMonth, ("month"));
   return element && element->formControlType() == kMonth;
 }
 
+bool IsPasswordInput(const WebInputElement* element) {
+  CR_DEFINE_STATIC_LOCAL(WebString, kPassword, ("password"));
+  return element && element->formControlType() == kPassword;

[Ilya Sherman, 2014/03/21 22:35:19]

There is already an "element.isPasswordField()" method.

[ziran.sun, 2014/03/25 18:25:26]

Done.

+}
+
 // All text fields, including password fields, should be extracted.
 bool IsTextInput(const WebInputElement* element) {
   return element && element->isTextField();
 }
 
 bool IsSelectElement(const WebFormControlElement& element) {
   // Static for improved performance.
   CR_DEFINE_STATIC_LOCAL(WebString, kSelectOne, ("select-one"));
   return element.formControlType() == kSelectOne;
 }
@@ skipping 388 matching lines @@
 
   ForEachMatchingFormField(form_element,
                            element,
                            form,
                            FILTER_ALL_NON_EDITIABLE_ELEMENTS,
                            false, /* dont force override */
                            &PreviewFormField);
 }
 
 bool ClearPreviewedFormWithElement(const WebInputElement& element,
-                                   bool was_autofilled) {
+                                   RequirementsMask requirements,
+                                   bool was_autofilled,
+                                   bool was_password_autofilled) {
   WebFormElement form_element = element.form();
   if (form_element.isNull())
     return false;
 
   std::vector<WebFormControlElement> control_elements;
-  ExtractAutofillableElements(form_element, REQUIRE_AUTOCOMPLETE,
-                              &control_elements);
+  ExtractAutofillableElements(form_element, requirements, &control_elements);

[Ilya Sherman, 2014/03/21 22:35:19]

Hmm, would anything go wrong if we were to just always extract elements with
REQUIRE_NONE?  The if-stmt on line 1080 makes me think that the requirement mask
isn't actually needed when extracting elements.

[ziran.sun, 2014/03/25 18:25:26]

I feel that it might be safe to use REQUIRE_NONE here. browser_tests hasn't give
any complain. Any other tests that I should verify? I will need to clean the
code in autofill_agent.cc if calling REQUIRE_NONE is good enough here. 

[Ilya Sherman, 2014/03/25 19:45:27]

I think since neither of us sees any reason not to use REQUIRE_NONE here, let's
go for it.  You could launch a try bot run to double-check that no tests
complain, if you'd like to be extra sure.

   for (size_t i = 0; i < control_elements.size(); ++i) {
     // There might be unrelated elements in this form which have already been
     // auto-filled.  For example, the user might have already filled the address
     // part of a form and now be dealing with the credit card section.  We only
     // want to reset the auto-filled status for fields that were previewed.
     WebFormControlElement control_element = control_elements[i];
 
     // Only text input and textarea elements can be previewed.
     WebInputElement* input_element = toWebInputElement(&control_element);
     if (!IsTextInput(input_element) &&
@@ skipping 14 matching lines @@
          control_element.to<WebTextAreaElement>().suggestedValue().isEmpty()))
       continue;
 
     // Clear the suggested value. For the initiating node, also restore the
     // original value.
     if (IsTextInput(input_element) || IsMonthInput(input_element)) {
       input_element->setSuggestedValue(WebString());
       bool is_initiating_node = (element == *input_element);
       if (is_initiating_node)
         input_element->setAutofilled(was_autofilled);
+      else if (IsPasswordInput(input_element))
+        input_element->setAutofilled(was_password_autofilled);
       else
         input_element->setAutofilled(false);
 
       // Clearing the suggested value in the focused node (above) can cause
       // selection to be lost. We force selection range to restore the text
       // cursor.
       if (is_initiating_node) {
         int length = input_element->value().length();
         input_element->setSelectionRange(length, length);
       }
@@ skipping 84 matching lines @@
 
 gfx::RectF GetScaledBoundingBox(float scale, WebInputElement* element) {
   gfx::Rect bounding_box(element->boundsInViewportSpace());
   return gfx::RectF(bounding_box.x() * scale,
                     bounding_box.y() * scale,
                     bounding_box.width() * scale,
                     bounding_box.height() * scale);
 }
 
 }  // namespace autofill