Add "previewing on hover" support for password field.

components/autofill/content/renderer/autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 83 matching lines @@
   void OnFillForm(int query_id, const FormData& form);
   void OnPreviewForm(int query_id, const FormData& form);
 
   // For external Autofill selection.
   void OnClearForm();
   void OnClearPreviewedForm();
   void OnFillFieldWithValue(const base::string16& value);
   void OnPreviewFieldWithValue(const base::string16& value);
   void OnAcceptDataListSuggestion(const base::string16& value);
   void OnAcceptPasswordAutofillSuggestion(const base::string16& username);
+  void OnPreviewPassword(const base::string16& username);
 
   // Called when interactive autocomplete finishes.
   void OnRequestAutocompleteResult(
       blink::WebFormElement::AutocompleteResult result,
       const FormData& form_data);
 
   // Called when an autocomplete request succeeds or fails with the |result|.
   void FinishAutocompleteRequest(
       blink::WebFormElement::AutocompleteResult result);
 
@@ skipping 91 matching lines @@
   // Whether or not to ignore text changes.  Useful for when we're committing
   // a composition when we are defocusing the WebView and we don't want to
   // trigger an autofill popup to show.
   bool ignore_text_changes_;
 
   // Whether the Autofill popup is possibly visible.  This is tracked as a
   // performance improvement, so that the IPC channel isn't flooded with
   // messages to close the Autofill popup when it can't possibly be showing.
   bool is_popup_possibly_visible_;
 
+  // Whether the password is previewed. If true, the previewed username and
+  // password will be cleared on receiving ClearPreviewedForm message.
+  bool is_password_previewed_;

[Ilya Sherman, 2014/03/21 22:35:19]

Please move this state tracking and everything that depends on it into the
PasswordAutofillAgent class.

[ziran.sun, 2014/03/25 18:25:26]

Done.

+
   // Timestamp of first time forms are seen.
   base::TimeTicks forms_seen_timestamp_;
 
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
   friend class PasswordAutofillAgentTest;
   friend class RequestAutocompleteRendererTest;
   FRIEND_TEST_ALL_PREFIXES(AutofillRendererTest, FillFormElement);
   FRIEND_TEST_ALL_PREFIXES(AutofillRendererTest, SendDynamicForms);
   FRIEND_TEST_ALL_PREFIXES(AutofillRendererTest, ShowAutofillWarning);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, WaitUsername);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, SuggestionAccept);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, SuggestionSelect);
   FRIEND_TEST_ALL_PREFIXES(
       PasswordAutofillAgentTest,
       PasswordAutofillTriggersOnChangeEventsWaitForUsername);
   FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,
                            NoCancelOnMainFrameNavigateAfterDone);
   FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,
                            NoCancelOnSubframeNavigateAfterDone);
   FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,
                            InvokingTwiceOnlyShowsOnce);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_