Add "previewing on hover" support for password field.

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
@@ skipping 2819 matching lines @@
   expected.value = ASCIIToUTF16("?");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields2[2]);
 
   // Verify that the cursor position has been updated.
   EXPECT_EQ(0, firstname.selectionStart());
   EXPECT_EQ(0, firstname.selectionEnd());
 }
 
+TEST_F(FormAutofillTest, ClearPreviewedPassword) {
+  LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+           "  <INPUT type=\"text\" id=\"username\" value=\"Wyatt\"/>"
+           "  <INPUT type=\"password\" id=\"password\" autocomplete=\"off\"/>"
+           "  <INPUT type=\"submit\" value=\"Send\"/>"
+           "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  // Set the auto-filled attribute.
+  WebInputElement username =
+      web_frame->document().getElementById("username").to<WebInputElement>();
+  username.setAutofilled(true);
+  WebInputElement password =
+      web_frame->document().getElementById("password").to<WebInputElement>();
+  password.setAutofilled(true);
+
+  // Set the suggested values on password.
+  password.setSuggestedValue(ASCIIToUTF16("SuggestedPassword"));
+
+  // Clear the previewed fields.
+  EXPECT_TRUE(ClearPreviewedFormWithElement(password, REQUIRE_NONE, false,
+                                            true));
+
+  // Fields with empty suggestions are not modified.
+  EXPECT_EQ(ASCIIToUTF16("Wyatt"), username.value());
+  EXPECT_TRUE(username.suggestedValue().isEmpty());
+  EXPECT_TRUE(username.isAutofilled());
+
+  // Verify the previewed fields are cleared.
+  EXPECT_TRUE(password.value().isEmpty());
+  EXPECT_TRUE(password.suggestedValue().isEmpty());
+  EXPECT_FALSE(password.isAutofilled());

[Ilya Sherman, 2014/03/21 22:35:19]

Hmm, why is the password field no longer autofilled, given that the last
parameter to ClearPreviewedFormWithElement() is |true|, indicating that the
password field was previously autofilled?

Please fix this [or let me know why I'm wrong ;)], and also add additional test
coverage.  Specifically, please test all four combinations of the username and
password fields being previously autofilled or not.  Also, please test cases
where the username element has a non-empty suggestion vs. where it doesn't.

In addition to that, please add test coverage for the PasswordAutofillAgent
method responsible for previewing the suggestions.

[ziran.sun, 2014/03/25 18:25:26]

You are right. There is an error in the test code. I've corrected it. 

Added all four combinations of the username and
password fields being previously autofilled or not.

Added one test on empty suggestedValue for username. I didn't add non-empty
suggestedValue test since I feel that it's covered by the other 4 tests .

For PasswordAutofillAgent related test, do you mean add a browser test in
autofill_password_agent_browsertest.cc? Otherwise, there is
DidSelectAutofillSuggestion unittest covered in PasswordAutofillManagerTest
already. 

[Ilya Sherman, 2014/03/25 19:45:27]

Yes, I do mean that we should test the renderer code as well as the browser
code.  Though, you might want to hold off on working on that until you implement
the change to send both the username and password across IPC -- it ought to
simplify the renderer code, which will hopefully make it both clearer to see
what needs to be tested, and easier to test.

+}
+
 TEST_F(FormAutofillTest, ClearPreviewedFormWithElement) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"Wyatt\"/>"
            "  <INPUT type=\"text\" id=\"lastname\"/>"
            "  <INPUT type=\"text\" id=\"email\"/>"
            "  <INPUT type=\"email\" id=\"email2\"/>"
            "  <INPUT type=\"tel\" id=\"phone\"/>"
            "  <INPUT type=\"submit\" value=\"Send\"/>"
            "</FORM>");
 
@@ skipping 22 matching lines @@
       web_frame->document().getElementById("phone").to<WebInputElement>();
   phone.setAutofilled(true);
 
   // Set the suggested values on two of the elements.
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   email2.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   phone.setSuggestedValue(ASCIIToUTF16("650-777-9999"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(ClearPreviewedFormWithElement(lastname, false));
+  EXPECT_TRUE(ClearPreviewedFormWithElement(lastname, REQUIRE_AUTOCOMPLETE,
+                                            false, false));
 
   // Fields with empty suggestions suggestions are not modified.
   EXPECT_EQ(ASCIIToUTF16("Wyatt"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_TRUE(firstname.isAutofilled());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
   EXPECT_TRUE(lastname.suggestedValue().isEmpty());
   EXPECT_FALSE(lastname.isAutofilled());
@@ skipping 49 matching lines @@
 
 
   // Set the suggested values on all of the elements.
   firstname.setSuggestedValue(ASCIIToUTF16("Wyatt"));
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   email2.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   phone.setSuggestedValue(ASCIIToUTF16("650-777-9999"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, false));
+  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, REQUIRE_AUTOCOMPLETE,
+                                            false, false));
 
   // Fields with non-empty values are restored.
   EXPECT_EQ(ASCIIToUTF16("W"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_FALSE(firstname.isAutofilled());
   EXPECT_EQ(1, firstname.selectionStart());
   EXPECT_EQ(1, firstname.selectionEnd());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
@@ skipping 46 matching lines @@
   phone.setAutofilled(true);
 
   // Set the suggested values on all of the elements.
   firstname.setSuggestedValue(ASCIIToUTF16("Wyatt"));
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   email2.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   phone.setSuggestedValue(ASCIIToUTF16("650-777-9999"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, true));
+  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, REQUIRE_AUTOCOMPLETE,
+                                            true, false));
 
   // Fields with non-empty values are restored.
   EXPECT_EQ(ASCIIToUTF16("W"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_TRUE(firstname.isAutofilled());
   EXPECT_EQ(1, firstname.selectionStart());
   EXPECT_EQ(1, firstname.selectionEnd());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
@@ skipping 184 matching lines @@
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 
 }  // namespace autofill