Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2084523002: Revert of V8: Remove obsolete environment variables (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of V8: Remove obsolete environment variables (patchset #1 id:1 of https://codereview.chromium.org/2074403002/ ) Reason for revert: Breaks internal... Original issue's description: > V8: Remove obsolete environment variables > > The target compiler for arm is controlled in v8's gyp files > now. > > BUG=474921 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/4e6b1681e8c0a5674c5d5f6ad3acd403dedba3e7 TBR=jochen@chromium.org,kjellander@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474921 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b12321a5304f334985b1092d9ac141e69ef20af8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/config.py View 1 chunk +6 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json View 3 chunks +8 lines, -2 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of V8: Remove obsolete environment variables
4 years, 6 months ago (2016-06-20 12:04:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084523002/1
4 years, 6 months ago (2016-06-20 12:04:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/b12321a5304f334985b1092d9ac141e69ef20af8
4 years, 6 months ago (2016-06-20 12:04:27 UTC) #5
kjellander_chromium
4 years, 6 months ago (2016-06-20 13:33:35 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698