third_party/WebKit/Source/platform/heap/GarbageCollected.h - Issue 2084513002: Store raw pointers in ScriptWrappableVisitor markind deque

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/GarbageCollected.h

Issue 2084513002: Store raw pointers in ScriptWrappableVisitor markind deque (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | third_party/WebKit/Source/platform/heap/TraceTraits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/GarbageCollected.h

diff --git a/third_party/WebKit/Source/platform/heap/GarbageCollected.h b/third_party/WebKit/Source/platform/heap/GarbageCollected.h

index 3624eba5d986fcd7c1672999aecee8b39d7a1d35..2f17304a8112f3e76040b4888790596d3f03c9f6 100644

--- a/third_party/WebKit/Source/platform/heap/GarbageCollected.h

+++ b/third_party/WebKit/Source/platform/heap/GarbageCollected.h

@@ -74,6 +74,7 @@ public:

virtual void trace(InlinedGlobalMarkingVisitor);

virtual void adjustAndMarkWrapper(const WrapperVisitor*) const = 0;

virtual bool isHeapObjectAlive() const = 0;

+ virtual HeapObjectHeader* adjustAndGetHeapObjectHeader() const = 0;

};

#define DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS(VISITOR, TYPE) \

@@ -97,9 +98,13 @@ public:

{ \

typedef WTF::IsSubclassOfTemplate<typename std::remove_const<TYPE>::type, blink::GarbageCollected> IsSubclassOfGarbageCollected; \

static_assert(IsSubclassOfGarbageCollected::value, "only garbage collected objects can have garbage collected mixins"); \

- if (visitor->markWrapperHeader(static_cast<const TYPE*>(this))) { \

- visitor->dispatchTraceWrappers(static_cast<const TYPE*>(this)); \

- } \

+ TraceTrait<TYPE>::markWrapper(visitor, static_cast<const TYPE*>(this)); \

+ } \

+ HeapObjectHeader* adjustAndGetHeapObjectHeader() const override \

+ { \

+ typedef WTF::IsSubclassOfTemplate<typename std::remove_const<TYPE>::type, blink::GarbageCollected> IsSubclassOfGarbageCollected; \

+ static_assert(IsSubclassOfGarbageCollected::value, "only garbage collected objects can have garbage collected mixins"); \

+ return TraceTrait<TYPE>::heapObjectHeader(static_cast<const TYPE*>(this)); \

} \

private: