Store raw pointers in ScriptWrappableVisitor markind deque

third_party/WebKit/Source/platform/heap/WrapperVisitor.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WrapperVisitor_h
 #define WrapperVisitor_h
 
 #include "platform/PlatformExport.h"
 #include "wtf/Allocator.h"
 
@@ skipping 79 matching lines @@
     USING_FAST_MALLOC(WrapperVisitor);
 public:
     template<typename T>
     void traceWrappers(const T* traceable) const
     {
         static_assert(sizeof(T), "T must be fully defined");
 
         if (!traceable)
             return;
 
-        TraceTrait<T>::markWrapper(this, traceable);
+        pushToMarkingDeque(

[haraken, 2016/06/20 11:10:38]

Won't this regress performance?

[Marcel Hlopko, 2016/06/20 11:29:13]

Good point! Added check for wrapperHeaderMark. I could mark object on push, and
expand during 
advancing marking This way objects are marked sooner and duplicated entries to
the marking 
deque are pushed. I just feel [ push, ..., pop, mark, expand ] is what people
expect, instead of 
[ mark, push, ..., pop, expand ]. Wdyt?

+            TraceTrait<T>::markWrapper,
+            TraceTrait<T>::heapObjectHeader,
+            traceable);
     }
 
     template<typename T>
     void traceWrappers(const Member<T>& t) const
     {
         traceWrappers(t.get());
     }
 
     virtual void traceWrappers(const ScopedPersistent<v8::Value>*) const = 0;
 
     virtual void dispatchTraceWrappers(const ScriptWrappable*) const = 0;
 #define DECLARE_DISPATCH_TRACE_WRAPPERS(className)                   \
     virtual void dispatchTraceWrappers(const className*) const = 0;
 
     WRAPPER_VISITOR_SPECIAL_CLASSES(DECLARE_DISPATCH_TRACE_WRAPPERS);
 
 #undef DECLARE_DISPATCH_TRACE_WRAPPERS
     virtual void dispatchTraceWrappers(const void*) const = 0;
 
-    virtual bool markWrapperHeader(const ScriptWrappable*) const = 0;
-    virtual bool markWrapperHeader(const void*) const = 0;
+    virtual bool markWrapperHeader(HeapObjectHeader*) const = 0;
+    virtual void markWrappersInAllWorlds(const ScriptWrappable*) const = 0;
+    virtual void markWrappersInAllWorlds(const void*) const = 0;
+    virtual void pushToMarkingDeque(
+        void (*traceWrappersCallback)(const WrapperVisitor*, const void*),
+        HeapObjectHeader* (*heapObjectHeaderCallback)(const void*),
+        const void*) const = 0;
 };
 
 } // namespace blink
 
 #endif // WrapperVisitor_h