Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2084483002: [turbofan] Only consider inhabited types for constant folding in typed lowering. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only consider inhabited types for constant folding in typed lowering. BUG=chromium:621423 Committed: https://crrev.com/50d6837ada127d0ec29e28ba0518cb44a533c493 Cr-Commit-Position: refs/heads/master@{#37092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -28 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +27 lines, -24 lines 0 comments Download
A + test/mjsunit/compiler/regress-621423.js View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-20 07:35:00 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-20 07:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084483002/1
4 years, 6 months ago (2016-06-20 07:53:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 07:55:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 07:56:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50d6837ada127d0ec29e28ba0518cb44a533c493
Cr-Commit-Position: refs/heads/master@{#37092}

Powered by Google App Engine
This is Rietveld 408576698