BlueZ + DBus implementations of create/remove service record functions.

BlueZ + DBus implementations of create/remove service record functions.

This CL adds the DBus and BlueZ implementations of the Create and
Remove service record functions. This adds a basic unit test but
we will need to add more tests to this.

Miao, I've had to change how we handle the service record data structures
since BlueZ will need both the type and size fields from use to correctly
infer the actual data type of the value.

R=mcchou@chromium.org, xiyuan@chromium.org
BUG=619669
Committed: https://crrev.com/2ffd561bdba4a20e0345ecdb97d798d4f82c4659
Cr-Commit-Position: refs/heads/master@{#401782}

[rkc, 2016-06-21 23:04:19]

Fixed to use service handle instead of service UUID. Also added tests for the
ServiceAttributeValue class, including testing for nested values.

[xiyuan, 2016-06-22 15:53:06]

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:27:
CHECK_EQ(type, SEQUENCE);
Since SEQUENCE is the only allowed type, why not omitting pass |type| in and
just init |type_| to it?

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:28:
CHECK_EQ(sequence->size(), size);
Same here. It seems we can init |size_| with sequence->size() instead of passing
in.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:44: for (const
auto& v : *attribute.value_.sequence)
Can we do:

  this->value_.sequence = new
std::vector<BluetoothServiceAttributeBlueZ>(*attribute.value_.sequence);

to create a copy?

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:35: union
ValueType {
Can we avoid using union and use two value accessors instead?

e.g.

  const base::Value& value() const { return *value_.get(); }
  const Sequence& sequence() const { return *sequence_.get(); }

 private:
  std::unique_ptr<base::Value> value_;
  std::unique_ptr<Sequence> sequence_;

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:40: using
AttributeValue = std::pair<Type, ValueType>;
not used?

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:45:
base::Value* value);
Make ownership transfer explicit by passing std::unique_ptr<base::Value>.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:48: Sequence*
sequence);
Same here, pass in std::unique_ptr<Sequence>

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:55: ValueType
get_value() const { return value_; }
nit: return a const ValueType?

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:60: ValueType
value_;
We only store a pointer in |value_|. Who is going to own the memory? If we don't
use unique_ptr, we should document the ownership.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_record_bluez.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez.cc:24:
std::vector<uint16_t> ids;
nit: ids.reserve(attributes_.size());

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:29: }
nit: insert one empty line before and add comment "// namespace"

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:58: size_t
old_error_callbacks = error_callbacks_;
nit: const for both old counts

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:78: size_t
old_error_callbacks = error_callbacks_;
nit: const for both old counts

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:125:
success_callbacks_++;
nit: ++success_callbacks_;

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:128: void
RemoveServiceSuccessCallback() { success_callbacks_++; }
nit: ++success_callbacks_;

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:131:
error_callbacks_++;
nit: ++error_callbacks_;

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_adapter_client.h (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_adapter_client.h:13: #include "base/callback.h"
Move to cc since we include callback_forward.h here.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_adapter_client.h:17: #include
"dbus/object_proxy.h"
nit: forward declare dbus::ObjectProxy and move this to cc

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_agent_service_provider.h (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_agent_service_provider.h:11: #include
"base/callback.h"
move to cc since callback_forward.h is included.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/f...
File device/bluetooth/dbus/fake_bluetooth_adapter_client.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/f...
device/bluetooth/dbus/fake_bluetooth_adapter_client.cc:242: last_handle_++;
nit: ++last_handle_

[rkc, 2016-06-22 21:06:38]

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:27:
CHECK_EQ(type, SEQUENCE);
On 2016/06/22 15:53:05, xiyuan wrote:
> Since SEQUENCE is the only allowed type, why not omitting pass |type| in and
> just init |type_| to it?

Makes sense.
Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:28:
CHECK_EQ(sequence->size(), size);
On 2016/06/22 15:53:05, xiyuan wrote:
> Same here. It seems we can init |size_| with sequence->size() instead of
passing
> in.

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:44: for (const
auto& v : *attribute.value_.sequence)
On 2016/06/22 15:53:05, xiyuan wrote:
> Can we do:
> 
>   this->value_.sequence = new
> std::vector<BluetoothServiceAttributeBlueZ>(*attribute.value_.sequence);
> 
> to create a copy?

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:35: union
ValueType {
On 2016/06/22 15:53:05, xiyuan wrote:
> Can we avoid using union and use two value accessors instead?
> 
> e.g.
> 
>   const base::Value& value() const { return *value_.get(); }
>   const Sequence& sequence() const { return *sequence_.get(); }
> 
>  private:
>   std::unique_ptr<base::Value> value_;
>   std::unique_ptr<Sequence> sequence_;

That does allow us to use unique_ptrs, which I really would prefer to use.
Thanks!

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:40: using
AttributeValue = std::pair<Type, ValueType>;
On 2016/06/22 15:53:05, xiyuan wrote:
> not used?

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:45:
base::Value* value);
On 2016/06/22 15:53:05, xiyuan wrote:
> Make ownership transfer explicit by passing std::unique_ptr<base::Value>.

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:48: Sequence*
sequence);
On 2016/06/22 15:53:05, xiyuan wrote:
> Same here, pass in std::unique_ptr<Sequence>

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:55: ValueType
get_value() const { return value_; }
On 2016/06/22 15:53:05, xiyuan wrote:
> nit: return a const ValueType?

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:60: ValueType
value_;
On 2016/06/22 15:53:05, xiyuan wrote:
> We only store a pointer in |value_|. Who is going to own the memory? If we
don't
> use unique_ptr, we should document the ownership.

We were storing a pointer both in |value_| and |sequence_| and were
conditionally deleting based on type. Your suggested approach is much cleaner.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_record_bluez.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez.cc:24:
std::vector<uint16_t> ids;
On 2016/06/22 15:53:05, xiyuan wrote:
> nit: ids.reserve(attributes_.size());

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:29: }
On 2016/06/22 15:53:06, xiyuan wrote:
> nit: insert one empty line before and add comment "// namespace"

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:58: size_t
old_error_callbacks = error_callbacks_;
On 2016/06/22 15:53:05, xiyuan wrote:
> nit: const for both old counts

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:78: size_t
old_error_callbacks = error_callbacks_;
On 2016/06/22 15:53:05, xiyuan wrote:
> nit: const for both old counts

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:125:
success_callbacks_++;
On 2016/06/22 15:53:05, xiyuan wrote:
> nit: ++success_callbacks_;

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:128: void
RemoveServiceSuccessCallback() { success_callbacks_++; }
On 2016/06/22 15:53:06, xiyuan wrote:
> nit: ++success_callbacks_;

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:131:
error_callbacks_++;
On 2016/06/22 15:53:05, xiyuan wrote:
> nit: ++error_callbacks_;

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_adapter_client.h (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_adapter_client.h:13: #include "base/callback.h"
On 2016/06/22 15:53:06, xiyuan wrote:
> Move to cc since we include callback_forward.h here.

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_adapter_client.h:17: #include
"dbus/object_proxy.h"
On 2016/06/22 15:53:06, xiyuan wrote:
> nit: forward declare dbus::ObjectProxy and move this to cc

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_agent_service_provider.h (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_agent_service_provider.h:11: #include
"base/callback.h"
On 2016/06/22 15:53:06, xiyuan wrote:
> move to cc since callback_forward.h is included.

Done.

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/f...
File device/bluetooth/dbus/fake_bluetooth_adapter_client.cc (right):

https://codereview.chromium.org/2084463002/diff/20001/device/bluetooth/dbus/f...
device/bluetooth/dbus/fake_bluetooth_adapter_client.cc:242: last_handle_++;
On 2016/06/22 15:53:06, xiyuan wrote:
> nit: ++last_handle_

Done.

[rkc, 2016-06-22 21:07:17]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[rkc, 2016-06-22 21:07:29]

The CQ bit was unchecked by rkc@chromium.org

[rkc, 2016-06-22 21:07:47]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 21:08:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084463002/30018

[xiyuan, 2016-06-22 21:28:44]

lgtm

Just nits

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc (right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:16: :
type_(type), size_(size), value_(std::move(value)), sequence_(nullptr) {
nit: nullptr for unique_ptr init is not necessary

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
(right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc:41:
Type::UUID, 16, base::WrapUnique(new base::StringValue(kServiceUuid)));
nit: learned from my other review, we can do

  base::MakeUnique<base::StringValue>(kServiceUuid);

here and other applicable places

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc (right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:98:
base::WrapUnique(new base::StringValue(uuid))));
nit: base::MakeUnique

[commit-bot: I haz the power, 2016-06-22 21:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 21:30:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Miao, 2016-06-23 10:49:05]

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h (right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:44: const
base::Value& value() const { return *value_.get(); }
I am working on the type conversion currently, and I realize that the usage of
base::Value is not friendly for the types which are not in the original list of
types defined in base::Value. Except for SEQUENCE, there is no subclass defined
for UINT UUID URL. So I am wondering how will values of these types be stored
and extracted from the given base::Value.

Although passing raw byte(s) is ugly, it can one way to go.

[rkc, 2016-06-23 19:55:44]

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc (right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc:16: :
type_(type), size_(size), value_(std::move(value)), sequence_(nullptr) {
On 2016/06/22 21:28:44, xiyuan wrote:
> nit: nullptr for unique_ptr init is not necessary

Done.

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h (right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h:44: const
base::Value& value() const { return *value_.get(); }
On 2016/06/23 10:49:05, Miao wrote:
> I am working on the type conversion currently, and I realize that the usage of
> base::Value is not friendly for the types which are not in the original list
of
> types defined in base::Value. Except for SEQUENCE, there is no subclass
defined
> for UINT UUID URL. So I am wondering how will values of these types be stored
> and extracted from the given base::Value.
> 
> Although passing raw byte(s) is ugly, it can one way to go.

Integer types should be stored as UInt32, UUID and URL as strings. I'll add this
to the tests in another CL.

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
(right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc:41:
Type::UUID, 16, base::WrapUnique(new base::StringValue(kServiceUuid)));
On 2016/06/22 21:28:44, xiyuan wrote:
> nit: learned from my other review, we can do
> 
>   base::MakeUnique<base::StringValue>(kServiceUuid);
> 
> here and other applicable places

Done.

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc (right):

https://codereview.chromium.org/2084463002/diff/30018/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc:98:
base::WrapUnique(new base::StringValue(uuid))));
On 2016/06/22 21:28:44, xiyuan wrote:
> nit: base::MakeUnique

Done.

[rkc, 2016-06-23 20:12:39]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 20:13:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084463002/70001

[commit-bot: I haz the power, 2016-06-23 20:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 20:31:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2016-06-23 22:29:38]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-06-23 22:29:38]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2084463002/#ps90001
(title: "build fix")

[commit-bot: I haz the power, 2016-06-23 22:30:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084463002/90001

[commit-bot: I haz the power, 2016-06-23 22:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 22:48:45]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2016-06-23 23:51:37]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-06-23 23:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2084463002/#ps110001
(title: "moar build fixes")

[commit-bot: I haz the power, 2016-06-23 23:52:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084463002/110001

[commit-bot: I haz the power, 2016-06-24 00:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 00:13:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2016-06-24 00:25:00]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-06-24 00:25:01]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2084463002/#ps130001
(title: ".")

[commit-bot: I haz the power, 2016-06-24 00:25:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084463002/130001

[commit-bot: I haz the power, 2016-06-24 02:00:36]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2016-06-24 02:03:19]

Description was changed from

==========
BlueZ + DBus implementations of create/remove service record functions.

This CL adds the DBus and BlueZ implementations of the Create and
Remove service record functions. This adds a basic unit test but
we will need to add more tests to this.

Miao, I've had to change how we handle the service record data structures
since BlueZ will need both the type and size fields from use to correctly
infer the actual data type of the value.


R=mcchou@chromium.org, xiyuan@chromium.org
BUG=619669
==========

to

==========
BlueZ + DBus implementations of create/remove service record functions.

This CL adds the DBus and BlueZ implementations of the Create and
Remove service record functions. This adds a basic unit test but
we will need to add more tests to this.

Miao, I've had to change how we handle the service record data structures
since BlueZ will need both the type and size fields from use to correctly
infer the actual data type of the value.

R=mcchou@chromium.org, xiyuan@chromium.org
BUG=619669

Committed: https://crrev.com/2ffd561bdba4a20e0345ecdb97d798d4f82c4659
Cr-Commit-Position: refs/heads/master@{#401782}
==========

[commit-bot: I haz the power, 2016-06-24 02:03:20]

Patchset 8 (id:??) landed as
https://crrev.com/2ffd561bdba4a20e0345ecdb97d798d4f82c4659
Cr-Commit-Position: refs/heads/master@{#401782}