Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2084443002: Remove all mojo and IPC dependencies on dynamic annotations. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all mojo and IPC dependencies on dynamic annotations. BUG=None TBR=jam@chromium.org for //ipc build files Committed: https://crrev.com/d12c4d7b5d8952f24b89a8becf2bd5a8b1cb2ae2 Cr-Commit-Position: refs/heads/master@{#400625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M ipc/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ipc/ipc.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M ipc/mojo/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/message_pump/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/mojo_base.gyp View 3 chunks +0 lines, -9 lines 0 comments Download
M mojo/mojo_edk.gyp View 4 chunks +0 lines, -4 lines 0 comments Download
M mojo/mojo_edk_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_public.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/mojo_public_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Anand Mistry (off Chromium)
This hasn't been necessary since late 2014. Time to get rid of it.
4 years, 6 months ago (2016-06-20 03:17:54 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-20 03:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084443002/1
4 years, 6 months ago (2016-06-20 04:04:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 04:53:59 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 04:56:52 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d12c4d7b5d8952f24b89a8becf2bd5a8b1cb2ae2
Cr-Commit-Position: refs/heads/master@{#400625}

Powered by Google App Engine
This is Rietveld 408576698