runtime/vm/scavenger.cc - Issue 208443002: Use a bit in the handle structure to indicate if it is a prologue weak handle instead of the taggin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scavenger.cc

Issue 208443002: Use a bit in the handle structure to indicate if it is a prologue weak handle instead of the taggin… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scavenger.cc

===================================================================

--- runtime/vm/scavenger.cc (revision 34251)

+++ runtime/vm/scavenger.cc (working copy)

@@ -279,13 +279,14 @@

prologue_weak_were_strong_(prologue_weak_were_strong) {

}

- void VisitHandle(uword addr, bool is_prologue_weak) {

+ void VisitHandle(uword addr) {

FinalizablePersistentHandle* handle =

reinterpret_cast<FinalizablePersistentHandle*>(addr);

RawObject** p = handle->raw_addr();

if (scavenger_->IsUnreachable(p)) {

- ASSERT(!is_prologue_weak || !prologue_weak_were_strong_);

- handle->UpdateUnreachable(isolate(), is_prologue_weak);

+ ASSERT(!handle->IsPrologueWeakPersistent() ||

+ !prologue_weak_were_strong_);

+ handle->UpdateUnreachable(isolate());

} else {

handle->UpdateRelocated(isolate());

}

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/verifier.h » ('j') | no next file with comments »