Correctly set 'firstPartyForCookies' in 'RenderFrameImpl::willSendRequest'.

Correctly set 'firstPartyForCookies' in 'RenderFrameImpl::willSendRequest'.

Currently, we're grabbing the top-level frame's document, and using its
'firstPartyForCookies'. This is incorrect, as it doesn't walk the ancestor
chain to verify same-siteness, and doubly incorrect as it punts entirely
if the top-level frame is in a different process.

alexmos@ fixed the underlying issue with the 'firstPartyForCookies' method
in https://codereview.chromium.org/2046593003, so we no longer need this
workaround.

This patch does require a small change to 'firstPartyForCookies' to deal
with imported documents, however; they don't have a frame, which the
current code doesn't check for, which leads to null-derefs in every test
that uses imports. This patch handles them by looking for their master
document, and returning its value.

R=jochen@chromium.org

Committed: https://crrev.com/b1d1a95d912c54d4183f05feb6d377380552b1f3
Cr-Commit-Position: refs/heads/master@{#401280}

[jochen (gone - plz use gerrit), 2016-06-22 08:46:25]

lgtm

[Mike West, 2016-06-22 13:45:01]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-06-22 13:45:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2084333002/#ps40001
(title: "Missed one.")

[commit-bot: I haz the power, 2016-06-22 13:45:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084333002/40001

[commit-bot: I haz the power, 2016-06-22 14:58:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-22 14:59:43]

Description was changed from

==========
Correctly set 'firstPartyForCookies' in 'RenderFrameImpl::willSendRequest'.

Currently, we're grabbing the top-level frame's document, and using its
'firstPartyForCookies'. This is incorrect, as it doesn't walk the ancestor
chain to verify same-siteness, and doubly incorrect as it punts entirely
if the top-level frame is in a different process.

alexmos@ fixed the underlying issue with the 'firstPartyForCookies' method
in https://codereview.chromium.org/2046593003, so we no longer need this
workaround.

This patch does require a small change to 'firstPartyForCookies' to deal
with imported documents, however; they don't have a frame, which the
current code doesn't check for, which leads to null-derefs in every test
that uses imports. This patch handles them by looking for their master
document, and returning its value.

R=jochen@chromium.org
==========

to

==========
Correctly set 'firstPartyForCookies' in 'RenderFrameImpl::willSendRequest'.

Currently, we're grabbing the top-level frame's document, and using its
'firstPartyForCookies'. This is incorrect, as it doesn't walk the ancestor
chain to verify same-siteness, and doubly incorrect as it punts entirely
if the top-level frame is in a different process.

alexmos@ fixed the underlying issue with the 'firstPartyForCookies' method
in https://codereview.chromium.org/2046593003, so we no longer need this
workaround.

This patch does require a small change to 'firstPartyForCookies' to deal
with imported documents, however; they don't have a frame, which the
current code doesn't check for, which leads to null-derefs in every test
that uses imports. This patch handles them by looking for their master
document, and returning its value.

R=jochen@chromium.org

Committed: https://crrev.com/b1d1a95d912c54d4183f05feb6d377380552b1f3
Cr-Commit-Position: refs/heads/master@{#401280}
==========

[commit-bot: I haz the power, 2016-06-22 14:59:44]

Patchset 3 (id:??) landed as
https://crrev.com/b1d1a95d912c54d4183f05feb6d377380552b1f3
Cr-Commit-Position: refs/heads/master@{#401280}