Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2084313002: Use alpha rather than inset rect for FakeRasterSource::CreateFilled. (Closed)

Created:
4 years, 6 months ago by wkorman
Modified:
4 years, 6 months ago
Reviewers:
vmpstr
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use alpha rather than inset rect for FakeRasterSource::CreateFilled. BUG=529938 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/2e7928680f0af8a1d5486499f41c58124b95f601 Cr-Commit-Position: refs/heads/master@{#401406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M cc/test/fake_raster_source.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
wkorman
Breakout from http://crrev.com/1484163002, can submit now as this is just an alternate approach for testing ...
4 years, 6 months ago (2016-06-22 01:14:25 UTC) #3
vmpstr
lgtm
4 years, 6 months ago (2016-06-22 18:20:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084313002/1
4 years, 6 months ago (2016-06-22 18:26:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/181544)
4 years, 6 months ago (2016-06-22 20:03:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084313002/1
4 years, 6 months ago (2016-06-22 20:10:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 21:15:43 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:18:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e7928680f0af8a1d5486499f41c58124b95f601
Cr-Commit-Position: refs/heads/master@{#401406}

Powered by Google App Engine
This is Rietveld 408576698