test/cctest/test-code-stubs-x64.cc - Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-code-stubs-x64.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: enum was converted into standard v8 macro Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-code-stubs-x64.cc

diff --git a/test/cctest/test-code-stubs-x64.cc b/test/cctest/test-code-stubs-x64.cc

index e30c160e7ab08d6bce785a42e8cfcf242bab3e10..0bffb87fef03fda8e88e27c7587ed4656897152e 100644

--- a/test/cctest/test-code-stubs-x64.cc

+++ b/test/cctest/test-code-stubs-x64.cc

@@ -93,7 +93,7 @@ ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,

if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) {

__ cmpq(reg, MemOperand(rsp, 0));

- __ Assert(equal, "register was clobbered");

+ __ Assert(equal, kRegisterWasClobbered);

__ addq(rsp, Immediate(kPointerSize));

}

« src/objects.cc ('K') | « test/cctest/test-code-stubs-ia32.cc ('k') | no next file » | no next file with comments »