src/ia32/stub-cache-ia32.cc - Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: enum was converted into standard v8 macro Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/ia32/stub-cache-ia32.cc

diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc

index 123506fa623592f72f03919f7949818b56f0d81a..dae5b323a5ad74e3335e57c732bcd46b98a926e2 100644

--- a/src/ia32/stub-cache-ia32.cc

+++ b/src/ia32/stub-cache-ia32.cc

@@ -3153,7 +3153,7 @@ Handle<Code> LoadStubCompiler::CompileLoadGlobal(

__ j(equal, &miss);

} else if (FLAG_debug_code) {

__ cmp(eax, factory()->the_hole_value());

- __ Check(not_equal, "DontDelete cells can't contain the hole");

+ __ Check(not_equal, kDontDeleteCellsCanTContainTheHole);

Jakob Kummerow 2013/08/01 12:02:13 nit: s/CanT/Cannot/

loislo 2013/08/01 13:15:30 Done.

}

HandlerFrontendFooter(name, &success, &miss);

« src/compiler.cc ('K') | « src/ia32/macro-assembler-ia32.cc ('k') | src/lithium.cc » ('j') | src/objects.h » ('J')