src/ia32/debug-ia32.cc - Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/debug-ia32.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: enum was converted into standard v8 macro Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/debug-ia32.cc

diff --git a/src/ia32/debug-ia32.cc b/src/ia32/debug-ia32.cc

index 68199f905b56633beb036ae0e5631ce830f691bc..fd703dcc0c7fb145e41f8cb97e0bbdc6a1fea124 100644

--- a/src/ia32/debug-ia32.cc

+++ b/src/ia32/debug-ia32.cc

@@ -128,7 +128,7 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

if ((non_object_regs & (1 << r)) != 0) {

if (FLAG_debug_code) {

__ test(reg, Immediate(0xc0000000));

- __ Assert(zero, "Unable to encode value as smi");

+ __ Assert(zero, kUnableToEncodeValueAsSmi);

}

__ SmiTag(reg);

__ push(reg);

« src/compiler.cc ('K') | « src/ia32/codegen-ia32.cc ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | src/ia32/stub-cache-ia32.cc » ('J')