Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/debug-mips.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 ASSERT((object_regs & ~kJSCallerSaved) == 0); 135 ASSERT((object_regs & ~kJSCallerSaved) == 0);
136 ASSERT((non_object_regs & ~kJSCallerSaved) == 0); 136 ASSERT((non_object_regs & ~kJSCallerSaved) == 0);
137 ASSERT((object_regs & non_object_regs) == 0); 137 ASSERT((object_regs & non_object_regs) == 0);
138 if ((object_regs | non_object_regs) != 0) { 138 if ((object_regs | non_object_regs) != 0) {
139 for (int i = 0; i < kNumJSCallerSaved; i++) { 139 for (int i = 0; i < kNumJSCallerSaved; i++) {
140 int r = JSCallerSavedCode(i); 140 int r = JSCallerSavedCode(i);
141 Register reg = { r }; 141 Register reg = { r };
142 if ((non_object_regs & (1 << r)) != 0) { 142 if ((non_object_regs & (1 << r)) != 0) {
143 if (FLAG_debug_code) { 143 if (FLAG_debug_code) {
144 __ And(at, reg, 0xc0000000); 144 __ And(at, reg, 0xc0000000);
145 __ Assert( 145 __ Assert(eq, kUnableToEncodeValueAsSmi, at, Operand(zero_reg));
146 eq, "Unable to encode value as smi", at, Operand(zero_reg));
147 } 146 }
148 __ sll(reg, reg, kSmiTagSize); 147 __ sll(reg, reg, kSmiTagSize);
149 } 148 }
150 } 149 }
151 __ MultiPush(object_regs | non_object_regs); 150 __ MultiPush(object_regs | non_object_regs);
152 } 151 }
153 152
154 #ifdef DEBUG 153 #ifdef DEBUG
155 __ RecordComment("// Calling from debug break to runtime - come in - over"); 154 __ RecordComment("// Calling from debug break to runtime - come in - over");
156 #endif 155 #endif
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 317
319 318
320 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) { 319 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) {
321 // In the places where a debug break slot is inserted no registers can contain 320 // In the places where a debug break slot is inserted no registers can contain
322 // object pointers. 321 // object pointers.
323 Generate_DebugBreakCallHelper(masm, 0, 0); 322 Generate_DebugBreakCallHelper(masm, 0, 0);
324 } 323 }
325 324
326 325
327 void Debug::GeneratePlainReturnLiveEdit(MacroAssembler* masm) { 326 void Debug::GeneratePlainReturnLiveEdit(MacroAssembler* masm) {
328 masm->Abort("LiveEdit frame dropping is not supported on mips"); 327 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnMips);
329 } 328 }
330 329
331 330
332 void Debug::GenerateFrameDropperLiveEdit(MacroAssembler* masm) { 331 void Debug::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {
333 masm->Abort("LiveEdit frame dropping is not supported on mips"); 332 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnMips);
334 } 333 }
335 334
336 335
337 const bool Debug::kFrameDropperSupported = false; 336 const bool Debug::kFrameDropperSupported = false;
338 337
339 #undef __ 338 #undef __
340 339
341 340
342 #endif // ENABLE_DEBUGGER_SUPPORT 341 #endif // ENABLE_DEBUGGER_SUPPORT
343 342
344 } } // namespace v8::internal 343 } } // namespace v8::internal
345 344
346 #endif // V8_TARGET_ARCH_MIPS 345 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« src/compiler.cc ('K') | « src/mips/codegen-mips.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698