Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/codegen-mips.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 282
283 __ Branch(&entry); 283 __ Branch(&entry);
284 284
285 // Hole found, store the-hole NaN. 285 // Hole found, store the-hole NaN.
286 __ bind(&convert_hole); 286 __ bind(&convert_hole);
287 if (FLAG_debug_code) { 287 if (FLAG_debug_code) {
288 // Restore a "smi-untagged" heap object. 288 // Restore a "smi-untagged" heap object.
289 __ SmiTag(t5); 289 __ SmiTag(t5);
290 __ Or(t5, t5, Operand(1)); 290 __ Or(t5, t5, Operand(1));
291 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 291 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
292 __ Assert(eq, "object found in smi-only array", at, Operand(t5)); 292 __ Assert(eq, kObjectFoundInSmiOnlyArray, at, Operand(t5));
293 } 293 }
294 __ sw(t0, MemOperand(t3)); // mantissa 294 __ sw(t0, MemOperand(t3)); // mantissa
295 __ sw(t1, MemOperand(t3, kIntSize)); // exponent 295 __ sw(t1, MemOperand(t3, kIntSize)); // exponent
296 __ Addu(t3, t3, kDoubleSize); 296 __ Addu(t3, t3, kDoubleSize);
297 297
298 __ bind(&entry); 298 __ bind(&entry);
299 __ Branch(&loop, lt, t3, Operand(t2)); 299 __ Branch(&loop, lt, t3, Operand(t2));
300 300
301 __ pop(ra); 301 __ pop(ra);
302 __ bind(&done); 302 __ bind(&done);
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 string, 482 string,
483 SeqTwoByteString::kHeaderSize - kHeapObjectTag); 483 SeqTwoByteString::kHeaderSize - kHeapObjectTag);
484 __ jmp(&check_encoding); 484 __ jmp(&check_encoding);
485 485
486 // Handle external strings. 486 // Handle external strings.
487 __ bind(&external_string); 487 __ bind(&external_string);
488 if (FLAG_debug_code) { 488 if (FLAG_debug_code) {
489 // Assert that we do not have a cons or slice (indirect strings) here. 489 // Assert that we do not have a cons or slice (indirect strings) here.
490 // Sequential strings have already been ruled out. 490 // Sequential strings have already been ruled out.
491 __ And(at, result, Operand(kIsIndirectStringMask)); 491 __ And(at, result, Operand(kIsIndirectStringMask));
492 __ Assert(eq, "external string expected, but not found", 492 __ Assert(eq, kExternalStringExpectedButNotFound,
493 at, Operand(zero_reg)); 493 at, Operand(zero_reg));
494 } 494 }
495 // Rule out short external strings. 495 // Rule out short external strings.
496 STATIC_CHECK(kShortExternalStringTag != 0); 496 STATIC_CHECK(kShortExternalStringTag != 0);
497 __ And(at, result, Operand(kShortExternalStringMask)); 497 __ And(at, result, Operand(kShortExternalStringMask));
498 __ Branch(call_runtime, ne, at, Operand(zero_reg)); 498 __ Branch(call_runtime, ne, at, Operand(zero_reg));
499 __ lw(string, FieldMemOperand(string, ExternalString::kResourceDataOffset)); 499 __ lw(string, FieldMemOperand(string, ExternalString::kResourceDataOffset));
500 500
501 Label ascii, done; 501 Label ascii, done;
502 __ bind(&check_encoding); 502 __ bind(&check_encoding);
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 patcher.masm()->dd(reinterpret_cast<uint32_t>(stub->instruction_start())); 659 patcher.masm()->dd(reinterpret_cast<uint32_t>(stub->instruction_start()));
660 } 660 }
661 } 661 }
662 662
663 663
664 #undef __ 664 #undef __
665 665
666 } } // namespace v8::internal 666 } } // namespace v8::internal
667 667
668 #endif // V8_TARGET_ARCH_MIPS 668 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« src/compiler.cc ('K') | « src/mips/code-stubs-mips.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698