Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3135 matching lines...) Expand 10 before | Expand all | Expand 10 after
3146 } else { 3146 } else {
3147 __ mov(eax, Operand::ForCell(cell)); 3147 __ mov(eax, Operand::ForCell(cell));
3148 } 3148 }
3149 3149
3150 // Check for deleted property if property can actually be deleted. 3150 // Check for deleted property if property can actually be deleted.
3151 if (!is_dont_delete) { 3151 if (!is_dont_delete) {
3152 __ cmp(eax, factory()->the_hole_value()); 3152 __ cmp(eax, factory()->the_hole_value());
3153 __ j(equal, &miss); 3153 __ j(equal, &miss);
3154 } else if (FLAG_debug_code) { 3154 } else if (FLAG_debug_code) {
3155 __ cmp(eax, factory()->the_hole_value()); 3155 __ cmp(eax, factory()->the_hole_value());
3156 __ Check(not_equal, "DontDelete cells can't contain the hole"); 3156 __ Check(not_equal, kDontDeleteCellsCannotContainTheHole);
3157 } 3157 }
3158 3158
3159 HandlerFrontendFooter(name, &success, &miss); 3159 HandlerFrontendFooter(name, &success, &miss);
3160 __ bind(&success); 3160 __ bind(&success);
3161 3161
3162 Counters* counters = isolate()->counters(); 3162 Counters* counters = isolate()->counters();
3163 __ IncrementCounter(counters->named_load_global_stub(), 1); 3163 __ IncrementCounter(counters->named_load_global_stub(), 1);
3164 // The code above already loads the result into the return register. 3164 // The code above already loads the result into the return register.
3165 __ ret(0); 3165 __ ret(0);
3166 3166
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
3766 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3766 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3767 } 3767 }
3768 } 3768 }
3769 3769
3770 3770
3771 #undef __ 3771 #undef __
3772 3772
3773 } } // namespace v8::internal 3773 } } // namespace v8::internal
3774 3774
3775 #endif // V8_TARGET_ARCH_IA32 3775 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« src/compiler.cc ('K') | « src/ia32/macro-assembler-ia32.cc ('k') | src/lithium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698