Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/ia32/deoptimizer-ia32.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 618
619 if (type() != OSR) { 619 if (type() != OSR) {
620 // If frame was dynamically aligned, pop padding. 620 // If frame was dynamically aligned, pop padding.
621 Label no_padding; 621 Label no_padding;
622 __ cmp(Operand(eax, Deoptimizer::has_alignment_padding_offset()), 622 __ cmp(Operand(eax, Deoptimizer::has_alignment_padding_offset()),
623 Immediate(0)); 623 Immediate(0));
624 __ j(equal, &no_padding); 624 __ j(equal, &no_padding);
625 __ pop(ecx); 625 __ pop(ecx);
626 if (FLAG_debug_code) { 626 if (FLAG_debug_code) {
627 __ cmp(ecx, Immediate(kAlignmentZapValue)); 627 __ cmp(ecx, Immediate(kAlignmentZapValue));
628 __ Assert(equal, "alignment marker expected"); 628 __ Assert(equal, kAlignmentMarkerExpected);
629 } 629 }
630 __ bind(&no_padding); 630 __ bind(&no_padding);
631 } else { 631 } else {
632 // If frame needs dynamic alignment push padding. 632 // If frame needs dynamic alignment push padding.
633 Label no_padding; 633 Label no_padding;
634 __ cmp(Operand(eax, Deoptimizer::has_alignment_padding_offset()), 634 __ cmp(Operand(eax, Deoptimizer::has_alignment_padding_offset()),
635 Immediate(0)); 635 Immediate(0));
636 __ j(equal, &no_padding); 636 __ j(equal, &no_padding);
637 __ push(Immediate(kAlignmentZapValue)); 637 __ push(Immediate(kAlignmentZapValue));
638 __ bind(&no_padding); 638 __ bind(&no_padding);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 SetFrameSlot(offset, value); 718 SetFrameSlot(offset, value);
719 } 719 }
720 720
721 721
722 #undef __ 722 #undef __
723 723
724 724
725 } } // namespace v8::internal 725 } } // namespace v8::internal
726 726
727 #endif // V8_TARGET_ARCH_IA32 727 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« src/compiler.cc ('K') | « src/ia32/debug-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698