Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 ASSERT((object_regs & non_object_regs) == 0); 121 ASSERT((object_regs & non_object_regs) == 0);
122 for (int i = 0; i < kNumJSCallerSaved; i++) { 122 for (int i = 0; i < kNumJSCallerSaved; i++) {
123 int r = JSCallerSavedCode(i); 123 int r = JSCallerSavedCode(i);
124 Register reg = { r }; 124 Register reg = { r };
125 if ((object_regs & (1 << r)) != 0) { 125 if ((object_regs & (1 << r)) != 0) {
126 __ push(reg); 126 __ push(reg);
127 } 127 }
128 if ((non_object_regs & (1 << r)) != 0) { 128 if ((non_object_regs & (1 << r)) != 0) {
129 if (FLAG_debug_code) { 129 if (FLAG_debug_code) {
130 __ test(reg, Immediate(0xc0000000)); 130 __ test(reg, Immediate(0xc0000000));
131 __ Assert(zero, "Unable to encode value as smi"); 131 __ Assert(zero, kUnableToEncodeValueAsSmi);
132 } 132 }
133 __ SmiTag(reg); 133 __ SmiTag(reg);
134 __ push(reg); 134 __ push(reg);
135 } 135 }
136 } 136 }
137 137
138 #ifdef DEBUG 138 #ifdef DEBUG
139 __ RecordComment("// Calling from debug break to runtime - come in - over"); 139 __ RecordComment("// Calling from debug break to runtime - come in - over");
140 #endif 140 #endif
141 __ Set(eax, Immediate(0)); // No arguments. 141 __ Set(eax, Immediate(0)); // No arguments.
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 363
364 const bool Debug::kFrameDropperSupported = true; 364 const bool Debug::kFrameDropperSupported = true;
365 365
366 #undef __ 366 #undef __
367 367
368 #endif // ENABLE_DEBUGGER_SUPPORT 368 #endif // ENABLE_DEBUGGER_SUPPORT
369 369
370 } } // namespace v8::internal 370 } } // namespace v8::internal
371 371
372 #endif // V8_TARGET_ARCH_IA32 372 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« src/compiler.cc ('K') | « src/ia32/codegen-ia32.cc ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698