Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 namespace v8 { 34 namespace v8 {
35 namespace internal { 35 namespace internal {
36 36
37 37
38 static LChunk* OptimizeGraph(HGraph* graph) { 38 static LChunk* OptimizeGraph(HGraph* graph) {
39 DisallowHeapAllocation no_allocation; 39 DisallowHeapAllocation no_allocation;
40 DisallowHandleAllocation no_handles; 40 DisallowHandleAllocation no_handles;
41 DisallowHandleDereference no_deref; 41 DisallowHandleDereference no_deref;
42 42
43 ASSERT(graph != NULL); 43 ASSERT(graph != NULL);
44 SmartArrayPointer<char> bailout_reason; 44 BailoutReason bailout_reason = kNoReason;
45 if (!graph->Optimize(&bailout_reason)) { 45 if (!graph->Optimize(&bailout_reason)) {
46 FATAL(bailout_reason.is_empty() ? "unknown" : *bailout_reason); 46 FATAL(GetBailoutReason(bailout_reason));
47 } 47 }
48 LChunk* chunk = LChunk::NewChunk(graph); 48 LChunk* chunk = LChunk::NewChunk(graph);
49 if (chunk == NULL) { 49 if (chunk == NULL) {
50 FATAL(graph->info()->bailout_reason()); 50 FATAL(GetBailoutReason(graph->info()->bailout_reason()));
51 } 51 }
52 return chunk; 52 return chunk;
53 } 53 }
54 54
55 55
56 class CodeStubGraphBuilderBase : public HGraphBuilder { 56 class CodeStubGraphBuilderBase : public HGraphBuilder {
57 public: 57 public:
58 CodeStubGraphBuilderBase(Isolate* isolate, HydrogenCodeStub* stub) 58 CodeStubGraphBuilderBase(Isolate* isolate, HydrogenCodeStub* stub)
59 : HGraphBuilder(&info_), 59 : HGraphBuilder(&info_),
60 arguments_length_(NULL), 60 arguments_length_(NULL),
(...skipping 874 matching lines...) Expand 10 before | Expand all | Expand 10 after
935 return value; 935 return value;
936 } 936 }
937 937
938 938
939 Handle<Code> ElementsTransitionAndStoreStub::GenerateCode() { 939 Handle<Code> ElementsTransitionAndStoreStub::GenerateCode() {
940 return DoGenerateCode(this); 940 return DoGenerateCode(this);
941 } 941 }
942 942
943 943
944 } } // namespace v8::internal 944 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/compiler.h » ('j') | src/compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698