Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/arm/debug-arm.cc

Issue 20843012: Extract hardcoded error strings into a single place and replace them with enum. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: styles fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 ASSERT((object_regs & ~kJSCallerSaved) == 0); 123 ASSERT((object_regs & ~kJSCallerSaved) == 0);
124 ASSERT((non_object_regs & ~kJSCallerSaved) == 0); 124 ASSERT((non_object_regs & ~kJSCallerSaved) == 0);
125 ASSERT((object_regs & non_object_regs) == 0); 125 ASSERT((object_regs & non_object_regs) == 0);
126 if ((object_regs | non_object_regs) != 0) { 126 if ((object_regs | non_object_regs) != 0) {
127 for (int i = 0; i < kNumJSCallerSaved; i++) { 127 for (int i = 0; i < kNumJSCallerSaved; i++) {
128 int r = JSCallerSavedCode(i); 128 int r = JSCallerSavedCode(i);
129 Register reg = { r }; 129 Register reg = { r };
130 if ((non_object_regs & (1 << r)) != 0) { 130 if ((non_object_regs & (1 << r)) != 0) {
131 if (FLAG_debug_code) { 131 if (FLAG_debug_code) {
132 __ tst(reg, Operand(0xc0000000)); 132 __ tst(reg, Operand(0xc0000000));
133 __ Assert(eq, "Unable to encode value as smi"); 133 __ Assert(eq, kUnableToEncodeValueAsSmi);
134 } 134 }
135 __ SmiTag(reg); 135 __ SmiTag(reg);
136 } 136 }
137 } 137 }
138 __ stm(db_w, sp, object_regs | non_object_regs); 138 __ stm(db_w, sp, object_regs | non_object_regs);
139 } 139 }
140 140
141 #ifdef DEBUG 141 #ifdef DEBUG
142 __ RecordComment("// Calling from debug break to runtime - come in - over"); 142 __ RecordComment("// Calling from debug break to runtime - come in - over");
143 #endif 143 #endif
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 306
307 307
308 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) { 308 void Debug::GenerateSlotDebugBreak(MacroAssembler* masm) {
309 // In the places where a debug break slot is inserted no registers can contain 309 // In the places where a debug break slot is inserted no registers can contain
310 // object pointers. 310 // object pointers.
311 Generate_DebugBreakCallHelper(masm, 0, 0); 311 Generate_DebugBreakCallHelper(masm, 0, 0);
312 } 312 }
313 313
314 314
315 void Debug::GeneratePlainReturnLiveEdit(MacroAssembler* masm) { 315 void Debug::GeneratePlainReturnLiveEdit(MacroAssembler* masm) {
316 masm->Abort("LiveEdit frame dropping is not supported on arm"); 316 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnArm);
317 } 317 }
318 318
319 319
320 void Debug::GenerateFrameDropperLiveEdit(MacroAssembler* masm) { 320 void Debug::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {
321 masm->Abort("LiveEdit frame dropping is not supported on arm"); 321 masm->Abort(kLiveEditFrameDroppingIsNotSupportedOnArm);
322 } 322 }
323 323
324 const bool Debug::kFrameDropperSupported = false; 324 const bool Debug::kFrameDropperSupported = false;
325 325
326 #undef __ 326 #undef __
327 327
328 328
329 329
330 #endif // ENABLE_DEBUGGER_SUPPORT 330 #endif // ENABLE_DEBUGGER_SUPPORT
331 331
332 } } // namespace v8::internal 332 } } // namespace v8::internal
333 333
334 #endif // V8_TARGET_ARCH_ARM 334 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | src/compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698