Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2084233002: cc: Move LayerImpl::AddChild and RemoveChild to LayerImplTestProperties (Closed)

Created:
4 years, 6 months ago by jaydasika
Modified:
4 years, 6 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, danakj+watch_chromium.org, posciak+watch_chromium.org, dshwang, jbroman, Justin Novosad, feature-media-reviews_chromium.org, Rik, f(malita), blink-reviews-platform-graphics_chromium.org, blink-reviews, cc-bugs_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move LayerImpl::AddChild and RemoveChild to LayerImplTestProperties BUG=602438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82 Cr-Commit-Position: refs/heads/master@{#401163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -334 lines) Patch
M cc/input/scrollbar_animation_controller_linear_fade_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/input/scrollbar_animation_controller_thinning_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/layers/layer_impl_test_properties.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/layer_impl_test_properties.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 3 chunks +20 lines, -20 lines 0 comments Download
M cc/layers/layer_list_iterator_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M cc/layers/layer_utils_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/video_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_test_common.h View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/test/layer_tree_json_parser_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/test_layer_tree_host_base.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 17 chunks +45 lines, -43 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 68 chunks +150 lines, -131 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 24 chunks +52 lines, -50 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jaydasika
PTAL
4 years, 6 months ago (2016-06-21 22:17:52 UTC) #3
ajuma
lgtm
4 years, 6 months ago (2016-06-21 23:19:28 UTC) #4
jaydasika
vollick : Can you review changes to platform/graphics ?
4 years, 6 months ago (2016-06-21 23:21:54 UTC) #5
Ian Vollick
On 2016/06/21 at 23:21:54, jaydasika wrote: > vollick : Can you review changes to platform/graphics ...
4 years, 6 months ago (2016-06-21 23:58:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084233002/1
4 years, 6 months ago (2016-06-22 00:16:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 02:08:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 02:11:22 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82
Cr-Commit-Position: refs/heads/master@{#401163}

Powered by Google App Engine
This is Rietveld 408576698