Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 208423013: Spec adjustments for well-known symbols (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M src/symbol.js View 1 5 chunks +19 lines, -18 lines 0 comments Download
M test/mjsunit/harmony/symbols.js View 1 chunk +22 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rossberg
6 years, 9 months ago (2014-03-24 10:21:55 UTC) #1
Michael Starzinger
https://codereview.chromium.org/208423013/diff/1/src/symbol.js File src/symbol.js (right): https://codereview.chromium.org/208423013/diff/1/src/symbol.js#newcode138 src/symbol.js:138: var attr = READ_ONLY | DONT_DELETE | DONT_ENUM; With ...
6 years, 9 months ago (2014-03-24 10:34:52 UTC) #2
rossberg
https://codereview.chromium.org/208423013/diff/1/src/symbol.js File src/symbol.js (right): https://codereview.chromium.org/208423013/diff/1/src/symbol.js#newcode138 src/symbol.js:138: var attr = READ_ONLY | DONT_DELETE | DONT_ENUM; On ...
6 years, 9 months ago (2014-03-24 15:10:06 UTC) #3
Michael Starzinger
LGTM.
6 years, 9 months ago (2014-03-24 15:11:20 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 9 months ago (2014-03-24 15:13:17 UTC) #5
rossberg
6 years, 9 months ago (2014-03-24 15:45:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698