Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 208423011: SRI: Add the 'integrity' attribute, and a SubresourceIntegrity runtime flag. (Closed)

Created:
6 years, 9 months ago by Mike West
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, gavinp+prerender_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, vcarbune.chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, arv+blink, watchdog-blink-watchlist_google.com, Inactive, jww
Visibility:
Public.

Description

SRI: Add the 'integrity' attribute, and a SubresourceIntegrity runtime flag. This patch adds a new flag to begin experimentation with the Subresource Integrity specification[1], and begins adding the minimal amount of functionality so we can test that the flag is working. That turns out to be the 'integrity' attribute on various HTML elements that we'll use later in order to do the actual verification. Intent to Implement at [2]. [1]: http://w3c.github.io/webappsec/specs/subresourceintegrity/ [2]: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hTDUpMk_TV8/t_rjlkKfgGgJ BUG=355467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170313

Patch Set 1 #

Patch Set 2 : Test. #

Total comments: 1

Patch Set 3 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/subresourceIntegrity/integrity-attribute.html View 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/subresourceIntegrity/integrity-attribute-expected.txt View 1 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLLinkElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLScriptElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
Hello, friendly API OWNER. :) Assuming no one objects to the intent to implement, would ...
6 years, 9 months ago (2014-03-24 09:30:24 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/208423011/diff/20001/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/208423011/diff/20001/Source/platform/RuntimeEnabledFeatures.in#newcode110 Source/platform/RuntimeEnabledFeatures.in:110: SubresourceIntegrity status=experimental maybe start with test?
6 years, 9 months ago (2014-03-24 12:04:19 UTC) #2
Mike West
On 2014/03/24 12:04:19, jochen wrote: > https://codereview.chromium.org/208423011/diff/20001/Source/platform/RuntimeEnabledFeatures.in > File Source/platform/RuntimeEnabledFeatures.in (right): > > https://codereview.chromium.org/208423011/diff/20001/Source/platform/RuntimeEnabledFeatures.in#newcode110 > ...
6 years, 9 months ago (2014-03-24 13:06:27 UTC) #3
jochen (gone - plz use gerrit)
ok, please wait for the blink-dev thread to resolve, otherwise lgtm
6 years, 9 months ago (2014-03-24 13:08:29 UTC) #4
Mike West
On 2014/03/24 13:08:29, jochen wrote: > ok, please wait for the blink-dev thread to resolve, ...
6 years, 9 months ago (2014-03-28 10:54:36 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 9 months ago (2014-03-28 10:54:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/208423011/40001
6 years, 9 months ago (2014-03-28 10:54:49 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 11:40:26 UTC) #8
Message was sent while issue was closed.
Change committed as 170313

Powered by Google App Engine
This is Rietveld 408576698