Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2084183003:
Disabling memory.top_7_stress perf test on webview (Closed)
|
Created:
4 years, 6 months ago by oystein (OOO til 10th of July) Modified:
4 years, 6 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisabling memory.top_7_stress perf test on webview
TBR=nednguyen
BUG=621489
Committed: https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5
Cr-Commit-Position: refs/heads/master@{#401241}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 ========== to ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 ==========
The CQ bit was checked by oysteine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084183003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by oysteine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084183003/1
Message was sent while issue was closed.
Description was changed from ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 ========== to ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 ========== to ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 Committed: https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 Cr-Commit-Position: refs/heads/master@{#401241} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 Cr-Commit-Position: refs/heads/master@{#401241}
Message was sent while issue was closed.
Description was changed from ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 Committed: https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 Cr-Commit-Position: refs/heads/master@{#401241} ========== to ========== Disabling memory.top_7_stress perf test on webview TBR=nednguyen BUG=621489 Committed: https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 Cr-Commit-Position: refs/heads/master@{#401241} ==========
Message was sent while issue was closed.
nednguyen@google.com changed reviewers: + perezju@chromium.org, petrcermak@chromium.org
Message was sent while issue was closed.
On 2016/06/22 09:52:01, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 > Cr-Commit-Position: refs/heads/master@{#401241} Juan, Petr: I just want to make sure that it's on our radar to kill this legacy memory one? How close are we from killing it?
Message was sent while issue was closed.
On 2016/06/22 13:14:57, nednguyen wrote: > On 2016/06/22 09:52:01, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 > > Cr-Commit-Position: refs/heads/master@{#401241} > > Juan, Petr: I just want to make sure that it's on our radar to kill this legacy > memory one? How close are we from killing it? I would really like to start killing this soon. The main reason to keep was measuring memory on desktop, but we're doing that now with Petr's system health benchmarks. Right?
Message was sent while issue was closed.
On 2016/06/23 09:20:44, perezju wrote: > On 2016/06/22 13:14:57, nednguyen wrote: > > On 2016/06/22 09:52:01, commit-bot: I haz the power wrote: > > > Patchset 1 (id:??) landed as > > > https://crrev.com/dfd52a7ddd4f276eec83f539790c9b2e89bdcce5 > > > Cr-Commit-Position: refs/heads/master@{#401241} > > > > Juan, Petr: I just want to make sure that it's on our radar to kill this > legacy > > memory one? How close are we from killing it? > > I would really like to start killing this soon. The main reason to keep was > measuring memory on desktop, but we're doing that now with Petr's system health > benchmarks. Right? Juan: Yes, memory system health benchmarks are running on *all* platforms including desktop (proof: https://chromeperf.appspot.com/report?sid=5ef3c568f66f25a9797c28c9fdb72c12202...). Unless someone else is tracking this benchmark (maybe we should send an email to telemetry-announce@?), I agree we should remove it. Thanks, Petr |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
