Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2197)

Issue 2084163004: gdb-v8-support.py: Fix old style print statement (Closed)

Created:
4 years, 6 months ago by honggyu.kim
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

gdb-v8-support.py: Fix old style print statement Since python3 does not use the old print statement, it may not be able to load gdb-v8-support.py script in gdb as below: (gdb) source tools/gdb-v8-support.py File "tools/gdb-v8-support.py", line 170 print result ^ SyntaxError: Missing parentheses in call to 'print' This fixes print statement for both python2 and python3. R=jochen@chromium.org BUG= Committed: https://crrev.com/c52685a516e9b3bf3c14dcb59356962206395bb0 Cr-Commit-Position: refs/heads/master@{#37488}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -1 line 1 comment Download
M tools/gdb-v8-support.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
honggyu.kim
4 years, 6 months ago (2016-06-23 05:37:42 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2084163004/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2084163004/diff/1/AUTHORS#newcode66 AUTHORS:66: Honggyu Kim <honggyu.kp@gmail.com> I don't really have a way ...
4 years, 6 months ago (2016-06-24 13:57:53 UTC) #2
Honggyu Kim
On 2016/06/24 13:57:53, jochen wrote: > https://codereview.chromium.org/2084163004/diff/1/AUTHORS > File AUTHORS (right): > > https://codereview.chromium.org/2084163004/diff/1/AUTHORS#newcode66 > ...
4 years, 5 months ago (2016-06-27 09:41:19 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-01 14:15:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2084163004/1
4 years, 5 months ago (2016-07-03 01:15:38 UTC) #6
honggyu.kim
On 2016/07/03 01:15:38, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-03 02:55:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-03 07:09:26 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-03 07:11:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c52685a516e9b3bf3c14dcb59356962206395bb0
Cr-Commit-Position: refs/heads/master@{#37488}

Powered by Google App Engine
This is Rietveld 408576698