content/browser/loader/resource_loader_unittest.cc - Issue 2084153003: Remove the test-only X509Certificate constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_loader_unittest.cc

Issue 2084153003: Remove the test-only X509Certificate constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixup .isolate for GYP build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/resource_loader_unittest.cc

diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc

index 0da06a122fbfc581fd4bbcaf0839d1e23855e1b0..cd03b832c39557533f415dff493975d8a59cc0e7 100644

--- a/content/browser/loader/resource_loader_unittest.cc

+++ b/content/browser/loader/resource_loader_unittest.cc

@@ -740,8 +740,7 @@ TEST_F(ClientCertResourceLoaderTest, WithStoreLookup) {

// Set up the test client cert store.

int store_request_count;

std::vector<std::string> store_requested_authorities;

- net::CertificateList dummy_certs(1, scoped_refptr<net::X509Certificate>(

- new net::X509Certificate("test", "test", base::Time(), base::Time())));

+ net::CertificateList dummy_certs(1, GetTestCert());

std::unique_ptr<ClientCertStoreStub> test_store(new ClientCertStoreStub(

dummy_certs, &store_request_count, &store_requested_authorities));

resource_context_.SetClientCertStore(std::move(test_store));