Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4538)

Unified Diff: chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc

Issue 2084153003: Remove the test-only X509Certificate constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixup .isolate for GYP build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
diff --git a/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc b/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
index b32eb2cf2f2b09c533b2bfa590ca09805ac6c8f6..ddb1fbd74458ff17d4d6441844fd20b8ab53b297 100644
--- a/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
+++ b/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
@@ -27,7 +27,9 @@
#include "components/syncable_prefs/testing_pref_service_syncable.h"
#include "components/user_manager/user_manager.h"
#include "content/public/test/test_browser_thread_bundle.h"
+#include "net/base/test_data_directory.h"
#include "net/cert/x509_certificate.h"
+#include "net/test/cert_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
@@ -439,8 +441,8 @@ TEST_F(MultiProfileUserControllerTest,
MultiProfileUserController::GetPrimaryUserPolicy());
net::CertificateList certificates;
- certificates.push_back(new net::X509Certificate(
- "subject", "issuer", base::Time(), base::Time()));
+ certificates.push_back(
+ net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem"));
Nico 2016/06/22 14:12:11 (is there a bug somewhere for making CertificateLi
Ryan Sleevi 2016/06/22 15:22:26 CertificateList takes scoped_refptr<>s
service->OnTrustAnchorsChanged(certificates);
EXPECT_TRUE(service->has_policy_certificates());
EXPECT_FALSE(controller()->IsUserAllowedInSession(
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_browsertest.cc » ('j') | chrome/browser/prerender/prerender_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698