Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3594)

Unified Diff: chrome/browser/ui/website_settings/website_settings_unittest.cc

Issue 2084153003: Remove the test-only X509Certificate constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings_unittest.cc
diff --git a/chrome/browser/ui/website_settings/website_settings_unittest.cc b/chrome/browser/ui/website_settings/website_settings_unittest.cc
index ef7d6bcb0421b33b38ad7a7aec67055d79bb95f7..6c38587b6a97969f704ee6b1008f699347480968 100644
--- a/chrome/browser/ui/website_settings/website_settings_unittest.cc
+++ b/chrome/browser/ui/website_settings/website_settings_unittest.cc
@@ -33,7 +33,9 @@
#include "net/cert/cert_status_flags.h"
#include "net/cert/x509_certificate.h"
#include "net/ssl/ssl_connection_status_flags.h"
+#include "net/test/cert_test_util.h"
#include "net/test/test_certificate_data.h"
+#include "net/test/test_data_directory.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -97,13 +99,9 @@ class WebsiteSettingsTest : public ChromeRenderViewHostTestHarness {
// Create the certificate.
cert_id_ = 1;
- base::Time start_date = base::Time::Now();
- base::Time expiration_date = base::Time::FromInternalValue(
- start_date.ToInternalValue() + base::Time::kMicrosecondsPerWeek);
- cert_ = new net::X509Certificate("subject",
- "issuer",
- start_date,
- expiration_date);
+ cert_ =
+ net::ImportCertFromFile(net::GetTestCertsDirectory(), "ok_cert.pem");
+ ASSERT_TRUE(cert_);
TabSpecificContentSettings::CreateForWebContents(web_contents());
InfoBarService::CreateForWebContents(web_contents());

Powered by Google App Engine
This is Rietveld 408576698