Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2084153002: [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents. BUG=330301 R=brettw@chromium.org Committed: https://crrev.com/d6fd033cbaddd2f127b244c48a3cfd8f7a3e953d Cr-Commit-Position: refs/heads/master@{#401320}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/docs/cookbook.md View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Robert Sesek
https://codereview.chromium.org/2084153002/diff/1/tools/gn/docs/cookbook.md File tools/gn/docs/cookbook.md (right): https://codereview.chromium.org/2084153002/diff/1/tools/gn/docs/cookbook.md#newcode225 tools/gn/docs/cookbook.md:225: | `mac_strip_release` | `enable_stripping` | `//build/config/mac/symbols.gni` | Looking at ...
4 years, 6 months ago (2016-06-21 20:23:04 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/2084153002/diff/1/tools/gn/docs/cookbook.md File tools/gn/docs/cookbook.md (right): https://codereview.chromium.org/2084153002/diff/1/tools/gn/docs/cookbook.md#newcode225 tools/gn/docs/cookbook.md:225: | `mac_strip_release` | `enable_stripping` | `//build/config/mac/symbols.gni` | On ...
4 years, 6 months ago (2016-06-21 21:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084153002/1
4 years, 6 months ago (2016-06-22 16:34:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 17:14:07 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:15:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6fd033cbaddd2f127b244c48a3cfd8f7a3e953d
Cr-Commit-Position: refs/heads/master@{#401320}

Powered by Google App Engine
This is Rietveld 408576698