media/base/android/ndk_media_codec_bridge.cc - Issue 2084143002: Make AVDA fall back to software decoding if needed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/android/ndk_media_codec_bridge.cc

Issue 2084143002: Make AVDA fall back to software decoding if needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed _l to auto_lock Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« media/base/android/media_codec_util.cc ('K') | « media/base/android/ndk_media_codec_bridge.h ('k') | media/base/android/sdk_media_codec_bridge.h » ('j') | media/gpu/android_video_decode_accelerator.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/base/android/ndk_media_codec_bridge.h"	5 #include "media/base/android/ndk_media_codec_bridge.h"

6	6

7 #include <media/NdkMediaError.h>	7 #include <media/NdkMediaError.h>

8 #include <media/NdkMediaFormat.h>	8 #include <media/NdkMediaFormat.h>

9	9

10 #include <limits>	10 #include <limits>

(...skipping 231 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
242 size_t offset,	242 size_t offset,

243 const uint8_t** addr,	243 const uint8_t** addr,

244 size_t* capacity) {	244 size_t* capacity) {

245 const uint8_t* src_data =	245 const uint8_t* src_data =

246 AMediaCodec_getOutputBuffer(media_codec_.get(), index, capacity);	246 AMediaCodec_getOutputBuffer(media_codec_.get(), index, capacity);

247 *addr = src_data + offset;	247 *addr = src_data + offset;

248 *capacity -= offset;	248 *capacity -= offset;

249 return MEDIA_CODEC_OK;	249 return MEDIA_CODEC_OK;

250 }	250 }

251	251

	252 bool NdkMediaCodecBridge::IsSoftwareCodec() {

	253 return false;
	watk 2016/06/22 22:39:46 Comment would be nice to say why we either can't t Comment would be nice to say why we either can't tell the truth or don't care. liberato (no reviews please) 2016/06/23 15:18:19 Done. Show quoted text On 2016/06/22 22:39:46, watk wrote: > Comment would be nice to say why we either can't tell the truth or don't care. Done.
	254 }

	255

252 } // namespace media	256 } // namespace media

OLD	NEW