Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 208413002: Update several iframes in geolocation browser_tests to be named (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update several iframes in geolocation browser_tests to be named Update several iframes in geolocation browser_tests to be named as the tests rely on the iframes name to be the same as their id. This change is needed as Blink will be updated so that an iframe's name is no longer set to its id when missing: https://codereview.chromium.org/187103002/ I checked that all the GeolocationBrowserTest.* browser_tests are now passing with the Blink-side patch. R=avi@chromium.org BUG=347169 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/test/data/geolocation/iframes_different_origin.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/geolocation/tab_destroyed.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 9 months ago (2014-03-21 15:42:27 UTC) #1
Michael van Ouwerkerk
lgtm Thanks! (I'm the owner/maintainer of Geolocation for Blink/Chromium generally)
6 years, 9 months ago (2014-03-21 16:09:41 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-21 16:10:41 UTC) #3
Avi (use Gerrit)
Thank you! LGTM I'm rewiring browser tests, and being able to locate iframes based on ...
6 years, 9 months ago (2014-03-21 16:10:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/208413002/1
6 years, 9 months ago (2014-03-21 16:11:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 20:15:58 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=286171
6 years, 9 months ago (2014-03-21 20:15:58 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-21 21:01:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/208413002/1
6 years, 9 months ago (2014-03-21 21:02:01 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 02:51:52 UTC) #10
Message was sent while issue was closed.
Change committed as 258743

Powered by Google App Engine
This is Rietveld 408576698