Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 2084103002: Rewrite scopes in computed properties in destructured parameters (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rewrite scopes in computed properties in destructured parameters While we properly handled scopes of initializers in destructured parameters, we never did the right thing for computed properties. This patch fixes that by factoring out PatternRewriter's scope rewriting logic and calls it for the computed property case. BUG=chromium:620119 Committed: https://crrev.com/f795a790100832ff8eb7aba29676efe6beff8ea8 Cr-Commit-Position: refs/heads/master@{#37228}

Patch Set 1 #

Patch Set 2 : Refactored and rebased on top of other fix #

Patch Set 3 : Fix dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -26 lines) Patch
M src/parsing/parser.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 2 3 chunks +38 lines, -26 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-620119.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 6 months ago (2016-06-23 20:11:07 UTC) #3
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-23 20:43:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084103002/40001
4 years, 6 months ago (2016-06-23 20:45:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-23 20:47:08 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 20:47:27 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f795a790100832ff8eb7aba29676efe6beff8ea8
Cr-Commit-Position: refs/heads/master@{#37228}

Powered by Google App Engine
This is Rietveld 408576698