Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 2084093003: Add input dependencies on installer test scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/mini_installer/mini_installer_test.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index a3dcae8d208547f31acbdf06f3d657c57dae44a0..53d8dbc49ada288e5e494e39bf4ff0ab868535a2 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -5,6 +5,7 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
import("//build_overrides/v8.gni")
+import("//chrome/test/mini_installer/mini_installer_test.gni")
import("//chrome/version.gni")
import("//third_party/icu/config.gni")
import("//ui/base/ui_features.gni")
@@ -38,9 +39,14 @@ source_set("lib") {
configs += [ ":mini_installer_compiler_flags" ]
- deps = [
- #"test_installer_sentinel", TODO(GYP) bug 521052.
- ]
+ # This input dependency on the mini installer test Python files will force a
+ # recompilation when any of the Python files have changed. This will then
+ # invalidate the build and trigger running the test on the bots even when
+ # no other Chrome files have changed. These have to be inputs rather than a
+ # dependency because a dependency won't actually trigger recompiles in
+ # incremental build cases unless a source file actually references one of the
+ # dependency outputs.
+ inputs = mini_installer_test_files
}
process_version("version") {
« no previous file with comments | « no previous file | chrome/test/mini_installer/mini_installer_test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698