Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chrome/browser/net/predictor_tab_helper.cc

Issue 2084093002: Use lossy prefs in the net predictor, and update them more frequently (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@predictor_lru
Patch Set: Fix browser tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/predictor_tab_helper.cc
diff --git a/chrome/browser/net/predictor_tab_helper.cc b/chrome/browser/net/predictor_tab_helper.cc
index 673701d040eb84de5340b2ad5d1d9574c50193b6..affe2ac6dea3945f33029a8416b90ed974f7a310 100644
--- a/chrome/browser/net/predictor_tab_helper.cc
+++ b/chrome/browser/net/predictor_tab_helper.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/net/predictor_tab_helper.h"
#include "base/feature_list.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/net/predictor.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/url_constants.h"
@@ -53,10 +54,22 @@ void PredictorTabHelper::DidStartNavigationToPendingEntry(
predicted_from_pending_entry_ = true;
}
+void PredictorTabHelper::DocumentOnLoadCompletedInMainFrame() {
+ Profile* profile =
+ Profile::FromBrowserContext(web_contents()->GetBrowserContext());
+ Predictor* predictor(profile->GetNetworkPredictor());
Bernhard Bauer 2016/07/29 11:07:53 Nit: I would use assignment here to initialize |pr
Charlie Harrison 2016/07/29 13:42:13 Done.
+#if defined(OS_CHROMEOS)
+ if (chromeos::ProfileHelper::IsSigninProfile(profile))
+ return;
+#endif
+ if (predictor)
+ predictor->SaveStateForNextStartup();
+}
+
void PredictorTabHelper::PreconnectUrl(const GURL& url) {
Profile* profile =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
- chrome_browser_net::Predictor* predictor = profile->GetNetworkPredictor();
+ Predictor* predictor(profile->GetNetworkPredictor());
if (predictor && url.SchemeIsHTTPOrHTTPS())
predictor->PreconnectUrlAndSubresources(url, GURL());
}

Powered by Google App Engine
This is Rietveld 408576698