Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2084083003: FLOG: Add examples/flog_viewer and always show MOJO_DLOG messages (Closed)

Created:
4 years, 6 months ago by dalesat
Modified:
4 years, 6 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

FLOG: Add examples/flog_viewer and always show MOJO_DLOG messages flog_viewer is a simple app that will show a list of the log files or dump a single log file. It can't format any channel messages, because it doesn't have access to the stubs that can deserialize them. It does show channel create and deletion messages as well as the MOJO_DLOG messages. There's also a change to the logging service to display MOJO_DLOG messages as they arrive. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eaaf5619d3c0613792dd1c9c1f2dcbdbcf19d976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -15 lines) Patch
M examples/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + examples/flog_viewer/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
A examples/flog_viewer/flog_viewer.cc View 1 chunk +255 lines, -0 lines 0 comments Download
M mojo/services/flog/interfaces/flog.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M services/flog/flog_logger_impl.h View 4 chunks +27 lines, -7 lines 0 comments Download
M services/flog/flog_logger_impl.cc View 4 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 6 months ago (2016-06-21 20:38:50 UTC) #3
kulakowski
lgtm
4 years, 6 months ago (2016-06-21 21:01:08 UTC) #4
dalesat
4 years, 6 months ago (2016-06-21 23:04:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eaaf5619d3c0613792dd1c9c1f2dcbdbcf19d976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698