Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2084063003: Merge M52: "Immediately reset for vp8 when there's nothing to flush." (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: "Immediately reset for vp8 when there's nothing to flush." If we finish playback of a clip up to end-of-stream, the codec is already Flush()'d so when we later recieve a Reset(), if we try to start another Flush() there is no event-pump driving the flush and we'll hang forever waiting for the flush that never was. The fix is to instead only flush when there are actually buffers in the decoder. If there are no buffers, there is nothing to flush. BUG=619967 TEST=looping video plays Review-Url: https://codereview.chromium.org/2074983002 Cr-Commit-Position: refs/heads/master@{#400338} (cherry picked from commit eec6e9013286349a66ace2ec0858c99e96132f46) Committed: https://chromium.googlesource.com/chromium/src/+/4424a3253f9b1a13799b53e60eb346b3e06c4104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 6 months ago (2016-06-22 01:36:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4424a3253f9b1a13799b53e60eb346b3e06c4104.

Powered by Google App Engine
This is Rietveld 408576698