third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js - Issue 2084053004: IndexedDB: Defer delete calls when there is a running upgrade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js

Issue 2084053004: IndexedDB: Defer delete calls when there is a running upgrade (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, made delete lists contain unique_ptrs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-versionchange.js ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/resources/testharness-helpers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js

diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js b/third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js

index 0f005763d11e640479b84078c93dabe62023e471..29bce0b311cd24ff10e7c093375b64eae4e2f806 100644

--- a/third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js

+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js

@@ -33,6 +33,7 @@ function prepareDatabase(evt)

request.onblocked = function deleteDatabaseOnBlocked(evt) {

preamble(evt);

shouldBeTrue("sawVersionChange");

+ evalAndLog("h.close()");

};

request.onsuccess = function deleteDatabaseOnSuccess(evt) {

preamble(evt);

@@ -45,9 +46,4 @@ function onOpenSuccess(evt)

{

preamble(evt);

evalAndLog("h = event.target.result");

- evalAndLog("h.close()");

- debug("Closing too late to prevent the in-flight 'blocked' event");

- // Event ordering between 'success' and 'blocked' is not strictly defined

- // in the spec. This documents current Chromium behavior to detect

- // unexpected changes.

}