Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js

Issue 2084053004: IndexedDB: Defer delete calls when there is a running upgrade (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, made delete lists contain unique_ptrs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js b/third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js
index 8e74fbfb5be492b0ec6f014c2911cbee5d585eb5..1c7b6264cb07993983d23f9d53b27eebe75a8858 100644
--- a/third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js
@@ -47,16 +47,10 @@ function openSuccess(evt)
{
preamble(evt);
shouldBeTrue("sawUpgradeNeeded");
- shouldBeTrue("sawVersionChange");
+ shouldBeFalse("sawVersionChange");
evalAndLog("sawOpenSuccess = true");
evalAndLog("db = event.target.result");
shouldBe('db.version', '1');
-
- // Event ordering between 'success' and 'blocked' is not strictly defined
- // in the spec. This documents current Chromium behavior to detect
- // unexpected changes.
- debug("Closing here is too late to prevent the in-flight 'blocked' event, but it does unblock the delete.");
- evalAndLog("db.close()");
}
function versionChangeCallback(evt)
@@ -64,7 +58,7 @@ function versionChangeCallback(evt)
preamble(evt);
shouldBe("event.oldVersion", "1");
shouldBeNull("event.newVersion");
- shouldBeFalse("sawOpenSuccess");
+ shouldBeTrue("sawOpenSuccess");
evalAndLog("sawVersionChange = true");
debug("Connection not closed at the end of 'versionchange', so 'blocked' should fire");
}
@@ -75,6 +69,7 @@ function deleteBlockedCallback(evt)
shouldBeTrue("sawVersionChange");
shouldBeTrue("sawOpenSuccess");
evalAndLog("sawDeleteBlocked = true");
+ evalAndLog("db.close()");
}
function deleteSuccessCallback(evt)

Powered by Google App Engine
This is Rietveld 408576698