third_party/WebKit/LayoutTests/storage/indexeddb/upgrade-delete-versionchange.html - Issue 2084053004: IndexedDB: Defer delete calls when there is a running upgrade

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/storage/indexeddb/upgrade-delete-versionchange.html

Issue 2084053004: IndexedDB: Defer delete calls when there is a running upgrade (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, made delete lists contain unique_ptrs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/resources/testharness-helpers.js ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/upgrade-multiple-deletes.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>IndexedDB: delete should be blocked by open/upgrade</title>

	3 <script src='../../resources/testharness.js'></script>

	4 <script src='../../resources/testharnessreport.js'></script>

	5 <script>

	6

	7 async_test(t => {

	8 let dbName = self.location.pathname + ' - ' + t.name;

	9 let delete_request = indexedDB.deleteDatabase(dbName);

	10 delete_request.onerror = t.unreached_func('deleteDatabase should not fail');

	11 delete_request.onsuccess = t.step_func(() => {

	12

	13 let saw_versionchange = false;

	14

	15 let open_request = indexedDB.open(dbName);

	16 open_request.onerror = t.unreached_func('open should succeed');

	17 open_request.onupgradeneeded = t.step_func(e => {

	18 let db = open_request.result;

	19 db.onversionchange =

	20 t.unreached_func('versionchange should not be seen before open s uccess');

	21 });

	22 open_request.onsuccess = t.step_func(e => {

	23 let db = open_request.result;

	24 db.onversionchange = e => {

	25 saw_versionchange = true;

	26 db.close();

	27 };

	28 });

	29

	30 let delete_request2 = indexedDB.deleteDatabase(dbName);

	31 delete_request2.onerror = t.unreached_func('deleteDatabase should not fa il');

	32 delete_request2.onblocked = t.unreached_func('blocked should not fire');

	33 delete_request2.onsuccess = t.step_func(e => {

	34 assert_true(saw_versionchange, 'delete should occur after versioncha nge');

	35 t.done();

	36 });

	37 });

	38 }, 'delete should be blocked by upgrade');

	39 </script>

OLD	NEW