Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2084043003: Touch emulator: clear mouse buttons modifiers on emulated touch events. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam, dtapuska+chromiumwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Touch emulator: clear mouse buttons modifiers on emulated touch events. Real touch events don't have mouse buttons modifiers which affect buttons property of synthesized from tap mouse events. BUG=621367 Committed: https://crrev.com/3af175cfb5381e32910b08ae3869eb5a5e19c0db Cr-Commit-Position: refs/heads/master@{#401399}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, renamed function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M content/browser/renderer_host/input/touch_emulator.cc View 1 4 chunks +9 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Could you please take a look?
4 years, 6 months ago (2016-06-21 18:06:35 UTC) #2
tdresser
LGTM % nit. https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_host/input/touch_emulator.cc File content/browser/renderer_host/input/touch_emulator.cc (right): https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_host/input/touch_emulator.cc#newcode42 content/browser/renderer_host/input/touch_emulator.cc:42: int ModifiersFromEvent(const WebInputEvent& event) { This ...
4 years, 6 months ago (2016-06-22 14:16:26 UTC) #3
dgozman
Thanks for review! https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_host/input/touch_emulator.cc File content/browser/renderer_host/input/touch_emulator.cc (right): https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_host/input/touch_emulator.cc#newcode42 content/browser/renderer_host/input/touch_emulator.cc:42: int ModifiersFromEvent(const WebInputEvent& event) { On ...
4 years, 6 months ago (2016-06-22 19:07:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084043003/20001
4 years, 6 months ago (2016-06-22 19:08:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 21:05:19 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:11:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3af175cfb5381e32910b08ae3869eb5a5e19c0db
Cr-Commit-Position: refs/heads/master@{#401399}

Powered by Google App Engine
This is Rietveld 408576698