Touch emulator: clear mouse buttons modifiers on emulated touch events.

Touch emulator: clear mouse buttons modifiers on emulated touch events.

Real touch events don't have mouse buttons modifiers which affect
buttons property of synthesized from tap mouse events.

BUG=621367
Committed: https://crrev.com/3af175cfb5381e32910b08ae3869eb5a5e19c0db
Cr-Commit-Position: refs/heads/master@{#401399}

[dgozman, 2016-06-21 18:06:35]

dgozman@chromium.org changed reviewers:
+ tdresser@chromium.org

[dgozman, 2016-06-21 18:06:35]

Could you please take a look?

[tdresser, 2016-06-22 14:16:26]

LGTM % nit.

https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_emulator.cc:42: int
ModifiersFromEvent(const WebInputEvent& event) {
This function is named a bit strangely.

Perhaps |ModifiersWithoutMouseButtons|, or something like that?

The name as is implies that it just returns event.modifiers.

[dgozman, 2016-06-22 19:07:55]

Thanks for review!

https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_emulator.cc (right):

https://codereview.chromium.org/2084043003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_emulator.cc:42: int
ModifiersFromEvent(const WebInputEvent& event) {
On 2016/06/22 14:16:26, tdresser wrote:
> This function is named a bit strangely.
> 
> Perhaps |ModifiersWithoutMouseButtons|, or something like that?
> 
> The name as is implies that it just returns event.modifiers.

Done.

[dgozman, 2016-06-22 19:08:02]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-06-22 19:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2084043003/#ps20001
(title: "rebase, renamed function")

[commit-bot: I haz the power, 2016-06-22 19:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084043003/20001

[commit-bot: I haz the power, 2016-06-22 21:05:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-22 21:11:41]

Description was changed from

==========
Touch emulator: clear mouse buttons modifiers on emulated touch events.

Real touch events don't have mouse buttons modifiers which affect
buttons property of synthesized from tap mouse events.

BUG=621367
==========

to

==========
Touch emulator: clear mouse buttons modifiers on emulated touch events.

Real touch events don't have mouse buttons modifiers which affect
buttons property of synthesized from tap mouse events.

BUG=621367

Committed: https://crrev.com/3af175cfb5381e32910b08ae3869eb5a5e19c0db
Cr-Commit-Position: refs/heads/master@{#401399}
==========

[commit-bot: I haz the power, 2016-06-22 21:11:42]

Patchset 2 (id:??) landed as
https://crrev.com/3af175cfb5381e32910b08ae3869eb5a5e19c0db
Cr-Commit-Position: refs/heads/master@{#401399}