Expose some internal PIN keyboard state.

Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/70e7ed2d59374a27f3b9922ac078f39f8ec05cb5
Cr-Commit-Position: refs/heads/master@{#401658}

[jdufault, 2016-06-21 19:17:03]

Description was changed from

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
==========

to

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-06-21 19:27:23]

Description was changed from

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-06-21 19:27:23]

jdufault@chromium.org changed reviewers:
+ xiyuan@chromium.org

[jdufault, 2016-06-21 19:28:16]

Xiyuan, PTAL. These changes are needed to implement the PIN unlock settings UI.

[xiyuan, 2016-06-21 20:16:24]

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:10: <dom-module
id="pin-keyboard">
Can we add some document for this polymer element? What properties does it
expose and what events does it fire etc.

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:31:
this.firePinChangeEvent_();
I wonder whether we can add an "observer" for |value| and fire the 'change'
event there instead of doing it explicitly (and using a timer in keydown
handler).

Would this work?

properties: {
  value: {
    type: String,
    notify: true,
    value: '',
    observer: 'valueChanged_'
  }
},
...
valueChanged_: function() {
  this.fire('change', { pin: this.value });
},
...

[jdufault, 2016-06-22 22:58:53]

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:10: <dom-module
id="pin-keyboard">
On 2016/06/21 20:16:24, xiyuan wrote:
> Can we add some document for this polymer element? What properties does it
> expose and what events does it fire etc.

Done.

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2084013003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:31:
this.firePinChangeEvent_();
On 2016/06/21 20:16:24, xiyuan wrote:
> I wonder whether we can add an "observer" for |value| and fire the 'change'
> event there instead of doing it explicitly (and using a timer in keydown
> handler).
> 
> Would this work?
> 
> properties: {
>   value: {
>     type: String,
>     notify: true,
>     value: '',
>     observer: 'valueChanged_'
>   }
> },
> ...
> valueChanged_: function() {
>   this.fire('change', { pin: this.value });
> },
> ...

Done. I think polymer is raising a 'change' event as well, so I've renamed the
event to 'pin-change'.

[xiyuan, 2016-06-23 01:16:54]

lgtm

https://codereview.chromium.org/2084013003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2084013003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:15: *    change:
Fired when the PIN value has changed. The pin is available at
nit: update this to 'pin-change'?

[jdufault, 2016-06-23 17:52:27]

https://codereview.chromium.org/2084013003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2084013003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:15: *    change:
Fired when the PIN value has changed. The pin is available at
On 2016/06/23 01:16:54, xiyuan wrote:
> nit: update this to 'pin-change'?

Done.

[jdufault, 2016-06-23 17:52:31]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-06-23 17:52:31]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2084013003/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2016-06-23 17:52:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084013003/40001

[commit-bot: I haz the power, 2016-06-23 18:38:03]

Description was changed from

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-23 18:38:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 18:51:28]

Description was changed from

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/70e7ed2d59374a27f3b9922ac078f39f8ec05cb5
Cr-Commit-Position: refs/heads/master@{#401658}
==========

[commit-bot: I haz the power, 2016-06-23 18:51:29]

Patchset 3 (id:??) landed as
https://crrev.com/70e7ed2d59374a27f3b9922ac078f39f8ec05cb5
Cr-Commit-Position: refs/heads/master@{#401658}