Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2083953002: Retain ref to RejectedPromises in RejectedPromises::handlerAdded (Closed)

Created:
4 years, 6 months ago by tzik
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, yhirano, hiroshige
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retain ref to RejectedPromises in RejectedPromises::handlerAdded Committed: https://crrev.com/67251d3f0b516663be76fed74f2b92728c765bc8 Cr-Commit-Position: refs/heads/master@{#400944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tzik
PTAL.
4 years, 6 months ago (2016-06-21 09:00:33 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-21 09:13:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083953002/1
4 years, 6 months ago (2016-06-21 09:22:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 10:39:47 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 10:41:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67251d3f0b516663be76fed74f2b92728c765bc8
Cr-Commit-Position: refs/heads/master@{#400944}

Powered by Google App Engine
This is Rietveld 408576698