core/fxge/ge/fx_ge_font.cpp - Issue 2083943003: Use FXFONT defines in place of integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/ge/fx_ge_font.cpp

Issue 2083943003: Use FXFONT defines in place of integers. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/ge/fx_ge_font.cpp

diff --git a/core/fxge/ge/fx_ge_font.cpp b/core/fxge/ge/fx_ge_font.cpp

index 3bb1580d014544f976029f80b638c7dac6c006a8..fd6f8a2cf803ead6ea89d97b96ab22e2df52d6f8 100644

--- a/core/fxge/ge/fx_ge_font.cpp

+++ b/core/fxge/ge/fx_ge_font.cpp

@@ -456,7 +456,8 @@ uint32_t CFX_UnicodeEncoding::GlyphFromCharCode(uint32_t charcode) {

if (FXFT_Select_Charmap(face, FXFT_ENCODING_UNICODE) == 0)

return FXFT_Get_Char_Index(face, charcode);

- if (m_pFont->GetSubstFont() && m_pFont->GetSubstFont()->m_Charset == 2) {

+ if (m_pFont->GetSubstFont() &&

+ m_pFont->GetSubstFont()->m_Charset == FXFONT_SYMBOL_CHARSET) {

uint32_t index = 0;

if (FXFT_Select_Charmap(face, FXFT_ENCODING_MS_SYMBOL) == 0)

index = FXFT_Get_Char_Index(face, charcode);