Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2083933004: Logging the NTP snippets request when verbose. (Closed)

Created:
4 years, 6 months ago by jkrcal
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Logging the NTP snippets request when verbose. BUG=621930 Committed: https://crrev.com/c53e56cc3afdbe74e918b83caa1fee5120b7c6c6 Cr-Commit-Position: refs/heads/master@{#401661}

Patch Set 1 #

Total comments: 4

Patch Set 2 : After code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/ntp_snippets/ntp_snippets_fetcher.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jkrcal
PTAL
4 years, 6 months ago (2016-06-21 14:32:33 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/2083933004/diff/1/components/ntp_snippets/ntp_snippets_fetcher.cc File components/ntp_snippets/ntp_snippets_fetcher.cc (right): https://codereview.chromium.org/2083933004/diff/1/components/ntp_snippets/ntp_snippets_fetcher.cc#newcode259 components/ntp_snippets/ntp_snippets_fetcher.cc:259: VLOG(1) << "Sendind a ntp snippets request to " ...
4 years, 6 months ago (2016-06-21 16:33:06 UTC) #3
jkrcal
PTAL, again. https://codereview.chromium.org/2083933004/diff/1/components/ntp_snippets/ntp_snippets_fetcher.cc File components/ntp_snippets/ntp_snippets_fetcher.cc (right): https://codereview.chromium.org/2083933004/diff/1/components/ntp_snippets/ntp_snippets_fetcher.cc#newcode259 components/ntp_snippets/ntp_snippets_fetcher.cc:259: VLOG(1) << "Sendind a ntp snippets request ...
4 years, 6 months ago (2016-06-23 08:21:36 UTC) #4
Bernhard Bauer
lgtm
4 years, 6 months ago (2016-06-23 11:37:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083933004/20001
4 years, 6 months ago (2016-06-23 17:09:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 18:41:58 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 18:51:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c53e56cc3afdbe74e918b83caa1fee5120b7c6c6
Cr-Commit-Position: refs/heads/master@{#401661}

Powered by Google App Engine
This is Rietveld 408576698