Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: chrome/browser/first_run/first_run_internal.h

Issue 208393020: Fix the new First Run sentinel file path determination. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync and rebase; re-upload to kick CQ. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/first_run/first_run_internal.h
diff --git a/chrome/browser/first_run/first_run_internal.h b/chrome/browser/first_run/first_run_internal.h
index 42e60899d07f84c1223cc652943f7ccae7582139..70e3de5b3ca3408a36678c139a00f3cfdb88a92a 100644
--- a/chrome/browser/first_run/first_run_internal.h
+++ b/chrome/browser/first_run/first_run_internal.h
@@ -34,22 +34,19 @@ void SetupMasterPrefsFromInstallPrefs(
const installer::MasterPreferences& install_prefs,
MasterPrefs* out_prefs);
-// Creates the sentinel file that signals that chrome has been configured.
+// Get the file path of the first run sentinel; returns false on failure.
+bool GetFirstRunSentinelFilePath(base::FilePath* path);
+
+// Create the first run sentinel file; returns false on failure.
bool CreateSentinel();
// -- Platform-specific functions --
void DoPostImportPlatformSpecificTasks(Profile* profile);
-// Gives the full path to the sentinel file. The file might not exist.
-// This function has a common implementation on OS_POSIX and a windows specific
-// implementation.
-bool GetFirstRunSentinelFilePath(base::FilePath* path);
-
-// Populates |path| with the old path to first run sentinel for the current
-// configuration. Returns true if there is a legacy path for this configuration
-// and it could be obtained.
-bool GetLegacyFirstRunSentinelFilePath(base::FilePath* path);
+// Returns true if the sentinel file exists (or the path cannot be obtained).
+// Migrates Windows legacy sentinel files to the corrent location, if needed.
+bool IsFirstRunSentinelPresent();
// This function has a common implementationin for all non-linux platforms, and
// a linux specific implementation.

Powered by Google App Engine
This is Rietveld 408576698