Fix the new First Run sentinel file path determination.

chrome/installer/util/install_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // See the corresponding header file for description of the functions in this
 // file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <shellapi.h>
@@ skipping 10 matching lines @@
 #include "base/platform_file.h"
 #include "base/process/launch.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/sys_info.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "base/win/metro.h"
 #include "base/win/registry.h"
 #include "base/win/windows_version.h"
+#include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_paths.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/installation_state.h"
 #include "chrome/installer/util/l10n_string_util.h"
 #include "chrome/installer/util/util_constants.h"
 #include "chrome/installer/util/work_item_list.h"
 
 using base::win::RegKey;
 using installer::ProductState;
@@ skipping 351 matching lines @@
   }
 
   return false;
 }
 
 bool InstallUtil::IsChromeSxSProcess() {
   static bool sxs = CheckIsChromeSxSProcess();
   return sxs;
 }
 
-bool InstallUtil::GetSentinelFilePath(
-    const base::FilePath::CharType* file,
-    BrowserDistribution* dist,
-    base::FilePath* path) {
+// static
+bool InstallUtil::IsFirstRunSentinelPresent() {
+  base::FilePath user_data_dir;

[grt (UTC plus 2), 2014/03/27 15:35:20]

please add something like:
  // This duplicates portions of code in first_run, but is required
  // here for use by the installer.

[msw, 2014/03/28 00:04:11]

Done (added a simple TODO).

+  return !PathService::Get(chrome::DIR_USER_DATA, &user_data_dir) ||
+         base::PathExists(user_data_dir.Append(chrome::kFirstRunSentinel));
+}
+
+// static
+bool InstallUtil::GetSentinelFilePath(const base::FilePath::CharType* file,

[grt (UTC plus 2), 2014/03/27 15:35:20]

this function is now only used to get the path for the EULA sentinel. in a
follow-on CL, please at least remove GetEULASentinelFilePath in
first_run_internal_win.cc and change this to be EULA-specific. maybe something
more grand makes sense, too. in a quick look at how it's used, i don't think it
needs to take a BrowserDistribution any longer.

[msw, 2014/03/28 00:04:11]

Yup, I'll follow up this CL with similar changes for the EULA sentinel.
It should use the proper user data dir, and there's room for cleanup.

+                                      BrowserDistribution* dist,
+                                      base::FilePath* path) {
+  // TODO(msw): Use PathService to obtain the correct DIR_USER_DATA.
   std::vector<base::FilePath> user_data_dir_paths;
   installer::GetChromeUserDataPaths(dist, &user_data_dir_paths);
 
   if (user_data_dir_paths.empty())
     return false;
   *path = user_data_dir_paths[0].Append(file);
   return true;
 }
 
 // This method tries to delete a registry key and logs an error message
@@ skipping 183 matching lines @@
   // Open the program and see if it references the expected file.
   base::File file;
   BY_HANDLE_FILE_INFORMATION info = {};
 
   return (OpenForInfo(path, &file) &&
           GetInfo(file, &info) &&
           info.dwVolumeSerialNumber == file_info_.dwVolumeSerialNumber &&
           info.nFileIndexHigh == file_info_.nFileIndexHigh &&
           info.nFileIndexLow == file_info_.nFileIndexLow);
 }