Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208393015: Revert "Remove desktop auto-login since we don't plan on shipping it there. Refactor the base and … (Closed)

Created:
6 years, 9 months ago by rohitrao (ping after 24h)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Remove desktop auto-login since we don't plan on shipping it there. Refactor the base and derived classes into one class since its android only now." This reverts commit d3eee07b9fe46ba6c0ebbe2dd040ead5961d50c6. TBR=rogerta NOTRY=True BUG=355071, 354988, 347214 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -707 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoLoginDelegate.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_startup_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/sync_section.html View 1 chunk +7 lines, -0 lines 0 comments Download
D chrome/browser/ui/android/infobars/auto_login_infobar_delegate.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/ui/android/infobars/auto_login_infobar_delegate.cc View 1 chunk +0 lines, -301 lines 0 comments Download
A chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 1 chunk +120 lines, -0 lines 0 comments Download
D chrome/browser/ui/android/infobars/auto_login_prompter.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/android/infobars/auto_login_prompter.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M chrome/browser/ui/android/infobars/infobar_container_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/auto_login_infobar_delegate.h View 5 chunks +4 lines, -21 lines 0 comments Download
A + chrome/browser/ui/auto_login_infobar_delegate.cc View 7 chunks +22 lines, -88 lines 0 comments Download
A + chrome/browser/ui/auto_login_prompter.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/auto_login_prompter.cc View 4 chunks +36 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rohitrao (ping after 24h)
drover is not reverting properly, so I'm going to try reverting this through the CQ ...
6 years, 9 months ago (2014-03-24 15:56:32 UTC) #1
rohitrao (ping after 24h)
The CQ bit was checked by rohitrao@chromium.org
6 years, 9 months ago (2014-03-24 15:57:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/208393015/1
6 years, 9 months ago (2014-03-24 15:57:31 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 15:58:38 UTC) #4
Message was sent while issue was closed. 
Change committed as 258940

Powered by Google App Engine
This is Rietveld 408576698