Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: Source/bindings/scripts/compute_interfaces_info.py

Issue 208393014: Remove [NoHeader] interface extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/generated_bindings.gyp ('k') | Source/bindings/scripts/generate_global_constructors.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/compute_interfaces_info.py
diff --git a/Source/bindings/scripts/compute_interfaces_info.py b/Source/bindings/scripts/compute_interfaces_info.py
index 5084d903111502a87044c4d88fa1f4b016d981dd..d0aeb02590853cc4018f28fe1260edbc2a4aa74e 100755
--- a/Source/bindings/scripts/compute_interfaces_info.py
+++ b/Source/bindings/scripts/compute_interfaces_info.py
@@ -161,10 +161,8 @@ def compute_individual_info(idl_filename):
extended_attributes = get_interface_extended_attributes_from_idl(idl_file_contents)
implemented_as = extended_attributes.get('ImplementedAs')
- # FIXME: remove [NoHeader] once switch to Python
this_include_path = (include_path(idl_filename, implemented_as)
- if ('ImplementedInBaseClass' not in extended_attributes
- and 'NoHeader' not in extended_attributes)
+ if 'ImplementedInBaseClass' not in extended_attributes
else None)
# Handle partial interfaces
« no previous file with comments | « Source/bindings/generated_bindings.gyp ('k') | Source/bindings/scripts/generate_global_constructors.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698